From ac9ebe294bc6fc6e9237dbc298416c8674bd4095 Mon Sep 17 00:00:00 2001 From: foreman Date: Wed, 8 Aug 2018 15:05:57 -0400 Subject: [PATCH] P4 to Git Change 1590896 by vsytchen@vsytchen-win10 on 2018/08/08 14:49:41 SWDEV-79445 - OCL generic changes and code clean-up 1. std::auto_ptr is deprecated in c++11 and removed in c++17. Use unique_ptr instead. ReviewBoardURL = http://ocltc.amd.com/reviews/r/15576/diff/ Affected files ... ... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palcompiler.cpp#23 edit ... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palprogram.cpp#65 edit ... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palprogram.hpp#21 edit --- rocclr/runtime/device/pal/palcompiler.cpp | 6 +++--- rocclr/runtime/device/pal/palprogram.cpp | 4 ++-- rocclr/runtime/device/pal/palprogram.hpp | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/rocclr/runtime/device/pal/palcompiler.cpp b/rocclr/runtime/device/pal/palcompiler.cpp index a0ef0698d6..3dbcde82b3 100644 --- a/rocclr/runtime/device/pal/palcompiler.cpp +++ b/rocclr/runtime/device/pal/palcompiler.cpp @@ -182,7 +182,7 @@ static void checkLLVM_BIN() { } #endif // defined(ATI_OS_LINUX) -std::auto_ptr LightningProgram::newCompilerInstance() { +std::unique_ptr LightningProgram::newCompilerInstance() { #if defined(ATI_OS_WIN) static INIT_ONCE initOnce; InitOnceExecuteOnce(&initOnce, checkLLVM_BIN, NULL, NULL); @@ -199,7 +199,7 @@ std::auto_ptr LightningProgram::newCompilerInstanc } #endif // defined(DEBUG) - return std::auto_ptr( + return std::unique_ptr( amd::opencl_driver::CompilerFactory().CreateAMDGPUCompiler(llvmBin_)); } @@ -207,7 +207,7 @@ bool LightningProgram::compileImpl(const std::string& sourceCode, const std::vector& headers, const char** headerIncludeNames, amd::option::Options* options) { using namespace amd::opencl_driver; - std::auto_ptr C(newCompilerInstance()); + std::unique_ptr C(newCompilerInstance()); std::vector inputs; Data* input = C->NewBufferReference(DT_CL, sourceCode.c_str(), sourceCode.length()); diff --git a/rocclr/runtime/device/pal/palprogram.cpp b/rocclr/runtime/device/pal/palprogram.cpp index 2be859a4c3..d72aca8412 100644 --- a/rocclr/runtime/device/pal/palprogram.cpp +++ b/rocclr/runtime/device/pal/palprogram.cpp @@ -1217,7 +1217,7 @@ bool LightningProgram::createBinary(amd::option::Options* options) { bool LightningProgram::linkImpl(const std::vector& inputPrograms, amd::option::Options* options, bool createLibrary) { using namespace amd::opencl_driver; - std::auto_ptr C(newCompilerInstance()); + std::unique_ptr C(newCompilerInstance()); std::vector inputs; for (auto program : (const std::vector&)inputPrograms) { @@ -1327,7 +1327,7 @@ bool LightningProgram::linkImpl(amd::option::Options* options) { return false; } - std::auto_ptr C(newCompilerInstance()); + std::unique_ptr C(newCompilerInstance()); // call LinkLLVMBitcode std::vector inputs; diff --git a/rocclr/runtime/device/pal/palprogram.hpp b/rocclr/runtime/device/pal/palprogram.hpp index 1bc291a5e2..0c472b2699 100644 --- a/rocclr/runtime/device/pal/palprogram.hpp +++ b/rocclr/runtime/device/pal/palprogram.hpp @@ -319,7 +319,7 @@ class LightningProgram : public HSAILProgram { virtual bool createBinary(amd::option::Options* options) override; //! Return a new transient compiler instance. - static std::auto_ptr newCompilerInstance(); + static std::unique_ptr newCompilerInstance(); private: CodeObjectMD* metadata_; //!< Runtime metadata