AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Deprecate enable/disable_callback/activity[_expl]

Browse Source 
These functions have little value as it is very unlikely an application
would want to enable all the domains.

Change-Id: I4743e8ddf6743e60c95c7ba5240950d2ef734301
This commit is contained in:
Laurent Morichetti
2022-09-06 18:57:20 -07:00
parent cfdfa2a2d4
commit ad01ba513a
3 changed files with 112 additions and 168 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/roctracer/backward_compat.cpp
+42
View File
@@ -25,3 +25,45 @@ extern "C" ROCTRACER_API int roctracer_load() { return 1; }
extern "C" ROCTRACER_API void roctracer_unload() {}
extern "C" ROCTRACER_API void roctracer_flush_buf() {}
extern "C" ROCTRACER_API void roctracer_mark(const char*) {}
ROCTRACER_API roctracer_status_t roctracer_enable_callback(roctracer_rtapi_callback_t callback,
void* user_data) {
for (uint32_t domain = 0; domain < ACTIVITY_DOMAIN_NUMBER; ++domain)
if (auto status =
roctracer_enable_domain_callback((roctracer_domain_t)domain, callback, user_data);
status != ROCTRACER_STATUS_SUCCESS)
return status;
return ROCTRACER_STATUS_SUCCESS;
}
ROCTRACER_API roctracer_status_t roctracer_disable_callback() {
for (uint32_t domain = 0; domain < ACTIVITY_DOMAIN_NUMBER; ++domain)
if (auto status = roctracer_disable_domain_callback((roctracer_domain_t)domain);
status != ROCTRACER_STATUS_SUCCESS)
return status;
return ROCTRACER_STATUS_SUCCESS;
}
ROCTRACER_API roctracer_status_t roctracer_enable_activity_expl(roctracer_pool_t* pool) {
for (uint32_t domain = 0; domain < ACTIVITY_DOMAIN_NUMBER; ++domain)
if (auto status = roctracer_enable_domain_activity_expl((roctracer_domain_t)domain, pool);
status != ROCTRACER_STATUS_SUCCESS)
return status;
return ROCTRACER_STATUS_SUCCESS;
}
ROCTRACER_API roctracer_status_t roctracer_enable_activity() {
for (uint32_t domain = 0; domain < ACTIVITY_DOMAIN_NUMBER; ++domain)
if (auto status = roctracer_enable_domain_activity((roctracer_domain_t)domain);
status != ROCTRACER_STATUS_SUCCESS)
return status;
return ROCTRACER_STATUS_SUCCESS;
}
ROCTRACER_API roctracer_status_t roctracer_disable_activity() {
for (uint32_t domain = 0; domain < ACTIVITY_DOMAIN_NUMBER; ++domain)
if (auto status = roctracer_disable_domain_activity((roctracer_domain_t)domain);
status != ROCTRACER_STATUS_SUCCESS)
return status;
return ROCTRACER_STATUS_SUCCESS;
}
src/roctracer/roctracer.cpp
-51
View File
@@ -696,17 +696,6 @@ ROCTRACER_API roctracer_status_t roctracer_enable_domain_callback(
API_METHOD_SUFFIX
}
ROCTRACER_API roctracer_status_t roctracer_enable_callback(roctracer_rtapi_callback_t callback,
void* user_data) {
API_METHOD_PREFIX
for (uint32_t domain = 0; domain < ACTIVITY_DOMAIN_NUMBER; ++domain) {
const uint32_t op_end = get_op_end(domain);
for (uint32_t op = get_op_begin(domain); op < op_end; ++op)
roctracer_enable_callback_impl((roctracer_domain_t)domain, op, callback, user_data);
}
API_METHOD_SUFFIX
}
// Disable runtime API callbacks
static void roctracer_disable_callback_fun(roctracer_domain_t domain, uint32_t op) {
switch (domain) {
@@ -777,16 +766,6 @@ ROCTRACER_API roctracer_status_t roctracer_disable_domain_callback(roctracer_dom
API_METHOD_SUFFIX
}
ROCTRACER_API roctracer_status_t roctracer_disable_callback() {
API_METHOD_PREFIX
for (uint32_t domain = 0; domain < ACTIVITY_DOMAIN_NUMBER; ++domain) {
const uint32_t op_end = get_op_end(domain);
for (uint32_t op = get_op_begin(domain); op < op_end; ++op)
roctracer_disable_callback_impl((roctracer_domain_t)domain, op);
}
API_METHOD_SUFFIX
}
// Return default pool and set new one if parameter pool is not NULL.
ROCTRACER_API roctracer_pool_t* roctracer_default_pool_expl(roctracer_pool_t* pool) {
std::lock_guard lock(memory_pool_mutex);
@@ -945,26 +924,6 @@ ROCTRACER_API roctracer_status_t roctracer_enable_domain_activity(activity_domai
API_METHOD_SUFFIX
}
static void roctracer_enable_activity_impl(roctracer_pool_t* pool) {
for (uint32_t domain = 0; domain < ACTIVITY_DOMAIN_NUMBER; ++domain) {
const uint32_t op_end = get_op_end(domain);
for (uint32_t op = get_op_begin(domain); op < op_end; ++op)
roctracer_enable_activity_impl((roctracer_domain_t)domain, op, pool);
}
}
ROCTRACER_API roctracer_status_t roctracer_enable_activity_expl(roctracer_pool_t* pool) {
API_METHOD_PREFIX
roctracer_enable_activity_impl(pool);
API_METHOD_SUFFIX
}
ROCTRACER_API roctracer_status_t roctracer_enable_activity() {
API_METHOD_PREFIX
roctracer_enable_activity_impl(nullptr);
API_METHOD_SUFFIX
}
// Disable activity records logging
static void roctracer_disable_activity_fun(roctracer_domain_t domain, uint32_t op) {
switch (domain) {
@@ -1042,16 +1001,6 @@ ROCTRACER_API roctracer_status_t roctracer_disable_domain_activity(roctracer_dom
API_METHOD_SUFFIX
}
ROCTRACER_API roctracer_status_t roctracer_disable_activity() {
API_METHOD_PREFIX
for (uint32_t domain = 0; domain < ACTIVITY_DOMAIN_NUMBER; ++domain) {
const uint32_t op_end = get_op_end(domain);
for (uint32_t op = get_op_begin(domain); op < op_end; ++op)
roctracer_disable_activity_impl((roctracer_domain_t)domain, op);
}
API_METHOD_SUFFIX
}
// Close memory pool
static void roctracer_close_pool_impl(roctracer_pool_t* pool) {
std::lock_guard lock(memory_pool_mutex);