Fix associate code object symbols with host allocation bug (#1799)

The current implementation skips this procedure for a given device
object when a global symbol is found in the cache.  This is incorrect:

 - There could be other undefined globals that have not been previously
encountered further down the list
 - If a symbol is found in the cache, it doesn't need to be pinned again
but it still need to be defined for the current executable

Added special case for the printf buffer symbol (already pinned by HCC)

The bug was exposed by running printf on different GPUs.

[ROCm/clr commit: 8fc7cad90f]
This commit is contained in:
Siu Chi Chan
2020-01-24 05:52:49 -05:00
committato da Maneesh Gupta
parent 64b531e782
commit adb93af8c3
3 ha cambiato i file con 50 aggiunte e 21 eliminazioni
+1 -1
Vedi File
@@ -61,7 +61,7 @@ namespace hip_impl {
if (it == impl->get_globals().end())
return nullptr;
else
return it->second;
return it->second.first;
}
hsa_executable_t program_state::load_executable(const char* data,