AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[rocprofiler-systems] Enable HOST OMPVV runtime-instrumentation CTests (#1970)

Browse Source 
* Enable HOST ompvv runtime-instrumentation ctests

* Fix rocprofiler-systems-avail-regex-negation test failure

* Exclude problematic function from instrumentation

* Make push pop skip an env option for ctests

* Remove SKIP_PUSH_POP_CHECK from argument parse

Co-authored-by: David Galiffi <David.Galiffi@amd.com>

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
This commit is contained in:
Kian Cossettini
2025-12-01 09:26:24 -05:00
committed by GitHub
parent 77f58ceb9f
commit ae29018bb0
6 changed files with 28 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/rocprofiler-systems/tests/rocprof-sys-binary-tests.cmake
+1 -1
View File
@@ -232,7 +232,7 @@ rocprofiler_systems_add_bin_test(
LABELS "rocprofiler-systems-avail"
TIMEOUT 45
PASS_REGEX
"ENVIRONMENT VARIABLE,[ \n]+ROCPROFSYS_THREAD_POOL_SIZE,[ \n]+ROCPROFSYS_USE_PID,[ \n]+"
"ENVIRONMENT VARIABLE,[ \n]+ROCPROFSYS_CI_SKIP_PUSH_POP_CHECK,[ \n]+ROCPROFSYS_THREAD_POOL_SIZE,[ \n]+ROCPROFSYS_USE_PID,[ \n]+"
FAIL_REGEX "ROCPROFSYS_TRACE|ROCPROFSYS_ABORT_FAIL_REGEX"
)
projects/rocprofiler-systems/tests/rocprof-sys-openmp-tests.cmake
+7 -3
View File
@@ -7,6 +7,11 @@
#
# ----------------------------------------------------------------------------- #
# Note:
# We do not receive the end of certain OMPT callbacks. This can result in missing completion events
# for the underlying functions that belong to the tracked host category (causing push vs pop mismatch).
# To avoid this, add ROCPROFSYS_CI_SKIP_PUSH_POP_CHECK=ON to the environment.
if(NOT EXISTS "${ROCM_LLVM_LIB_PATH}/libomptarget.so" AND ROCPROFSYS_USE_ROCM)
message(
FATAL_ERROR
@@ -112,18 +117,17 @@ endif()
if(ROCPROFSYS_OMPVV_HOST_TESTS)
foreach(HOST_TEST_NAME ${ROCPROFSYS_OMPVV_HOST_TESTS})
rocprofiler_systems_add_test(
SKIP_RUNTIME
NAME ${HOST_TEST_NAME}
TARGET ${HOST_TEST_NAME}-exec
LABELS "openmp;ompvv"
REWRITE_ARGS
-e -v 2 --instrument-loops
RUNTIME_ARGS
-e -v 1 --label return args -E ^GOMP
-e -v 1 --label return args
SAMPLING_TIMEOUT 300
REWRITE_TIMEOUT 300
ENVIRONMENT
"${_ompt_environment};ROCPROFSYS_USE_SAMPLING=ON;ROCPROFSYS_SAMPLING_FREQ=50;ROCPROFSYS_COUT_OUTPUT=ON"
"${_ompt_environment};ROCPROFSYS_COUT_OUTPUT=ON;ROCPROFSYS_CI_SKIP_PUSH_POP_CHECK=ON"
REWRITE_RUN_PASS_REGEX "${_OMPT_PASS_REGEX}"
REWRITE_FAIL_REGEX "0 instrumented loops in procedure"
)