Merge pull request #1515 from ansurya/tex_unbind_issue_fix

Fix undefined ref to hipUnbindTexture for texture types

hipamd/include/hip/nvcc_detail/hip_runtime_api.h

@@ -1398,6 +1398,11 @@ inline static hipError_t hipUnbindTexture(struct texture<T, dim, readMode>* tex)
     return hipCUDAErrorTohipError(cudaUnbindTexture(tex));
 }
 
+template <class T, int dim, enum hipTextureReadMode readMode>
+inline static hipError_t hipUnbindTexture(struct texture<T, dim, readMode> &tex) {
+    return hipCUDAErrorTohipError(cudaUnbindTexture(tex));
+}
+
 inline static hipError_t hipBindTexture(size_t* offset, textureReference* tex, const void* devPtr,
                                         const hipChannelFormatDesc* desc, size_t size = UINT_MAX){
     return hipCUDAErrorTohipError(cudaBindTexture(offset, tex, devPtr, desc, size));

hipamd/samples/2_Cookbook/11_texture_driver/texture2dDrv.cpp

@@ -124,6 +124,7 @@ bool runTest(int argc, char** argv) {
             }
         }
     }
+    HIP_CHECK(hipUnbindTexture(tex));
     HIP_CHECK(hipFree(dData));
     HIP_CHECK(hipFreeArray(array));
     return testResult;

hipamd/src/hip_texture.cpp

@@ -634,16 +634,15 @@ hipError_t hipBindTextureToMipmappedArray(textureReference* tex,
     return ihipLogStatus(hip_status);
 }
 
-hipError_t ihipUnbindTextureImpl(TlsData *tls, const hipTextureObject_t& textureObject) {
+hipError_t ihipUnbindTextureImpl(const hipTextureObject_t& textureObject) {
     hipError_t hip_status = hipSuccess;
-
+    TlsData* tls=tls_get_ptr();
     auto ctx = ihipGetTlsDefaultCtx();
     if (ctx) {
         hc::accelerator acc = ctx->getDevice()->_acc;
         auto device = ctx->getWriteableDevice();
 
         hsa_agent_t* agent = static_cast<hsa_agent_t*>(acc.get_hsa_agent());
-
         hipTexture* pTexture = textureHash[textureObject];
         if (pTexture != nullptr) {
             hsa_ext_image_destroy(*agent, pTexture->image);
@@ -659,7 +658,7 @@ hipError_t ihipUnbindTextureImpl(TlsData *tls, const hipTextureObject_t& texture
 hipError_t hipUnbindTexture(const textureReference* tex) {
     HIP_INIT_API(hipUnbindTexture, tex);
     hipError_t hip_status = hipSuccess;
-    hip_status = ihipUnbindTextureImpl(tls, tex->textureObject);
+    hip_status = ihipUnbindTextureImpl(tex->textureObject);
     return ihipLogStatus(hip_status);
 }
 

hipamd/tests/src/texture/hipNormalizedFloatValueTex.cpp

@@ -91,6 +91,7 @@ bool textureTest(enum hipArray_Format texFormat)
     }
     hipFree(dData);
     hipFree(dOutputData);
+    hipUnbindTexture(textureNormalizedVal_1D);
     delete [] hOutputData;
     return testResult;
 }

hipamd/tests/src/texture/hipTextureRef2D.cpp

@@ -90,6 +90,7 @@ int runTest(int argc, char** argv) {
             }
         }
     }
+    HIPCHECK(hipUnbindTexture(tex));
     hipFree(dData);
     hipFreeArray(hipArray);
     return testResult;