From b0b615091efcb7014ca4d4a7dc81957b7e323b0b Mon Sep 17 00:00:00 2001 From: Marius Brehler Date: Tue, 29 Apr 2025 23:18:51 +0200 Subject: [PATCH] Link `Threads::Threads` (#119) `pthread.h` is included in `src/common.h` but lib is not properly linked, resulting in the build failing with unresolved symbols when trying to link. [ROCm/rccl-tests commit: 5b27b961b2543b3af2bb1cf5ca8ee0505226ba92] --- projects/rccl-tests/CMakeLists.txt | 3 --- projects/rccl-tests/src/CMakeLists.txt | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/projects/rccl-tests/CMakeLists.txt b/projects/rccl-tests/CMakeLists.txt index e39d38b82b..cb08498032 100644 --- a/projects/rccl-tests/CMakeLists.txt +++ b/projects/rccl-tests/CMakeLists.txt @@ -124,9 +124,6 @@ endif() set(THREADS_PREFER_PTHREAD_FLAG ON) find_package(Threads REQUIRED) -##Adding pthread flag for linking -#set( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -pthread") - ## Check for HIP find_package(hip REQUIRED) message(STATUS "HIP compiler: ${HIP_COMPILER}") diff --git a/projects/rccl-tests/src/CMakeLists.txt b/projects/rccl-tests/src/CMakeLists.txt index 05824a42d0..6fe68236fd 100644 --- a/projects/rccl-tests/src/CMakeLists.txt +++ b/projects/rccl-tests/src/CMakeLists.txt @@ -126,7 +126,7 @@ add_custom_target(git_version_check add_custom_target(hipify DEPENDS ${HIP_COMMON_SOURCES}) add_library(rccl_common OBJECT ${HIP_COMMON_SOURCES}) add_dependencies(rccl_common hipify git_version_check) -target_link_libraries(rccl_common roc::rccl hip::device) +target_link_libraries(rccl_common roc::rccl hip::device Threads::Threads) if(USE_MPI) target_link_libraries(rccl_common MPI::MPI_CXX) endif()