From b382041b4f4af51050423449abfbd7914980db01 Mon Sep 17 00:00:00 2001 From: "Baraldi, Giovanni" Date: Mon, 31 Mar 2025 19:34:53 +0200 Subject: [PATCH] SWDEV-523436: Fix logging of code object id=0. Add perfevent test. (#318) * SWDEV-523436: Fix logging of code object id=0. Add perfevent test. * Apply suggestions from code review --------- Co-authored-by: Giovanni Baraldi [ROCm/rocprofiler-sdk commit: 48c672e23ec725bb6c9ecf76a77291bdd7b2da5b] --- .../source/lib/rocprofiler-sdk-att/att_lib_wrapper.cpp | 2 ++ .../lib/rocprofiler-sdk-att/tests/dummy_decoder.cpp | 8 ++++++++ 2 files changed, 10 insertions(+) diff --git a/projects/rocprofiler-sdk/source/lib/rocprofiler-sdk-att/att_lib_wrapper.cpp b/projects/rocprofiler-sdk/source/lib/rocprofiler-sdk-att/att_lib_wrapper.cpp index 5fbbef77f0..f345e4b6b1 100644 --- a/projects/rocprofiler-sdk/source/lib/rocprofiler-sdk-att/att_lib_wrapper.cpp +++ b/projects/rocprofiler-sdk/source/lib/rocprofiler-sdk-att/att_lib_wrapper.cpp @@ -139,6 +139,8 @@ ATTDecoder::parse(const Fspath& input_dir, for(const auto& file : codeobj_files) { + if(file.id == 0 && file.name.empty()) continue; + if(file.name.find("memory://") == 0) { ROCP_WARNING << file.name << " was not loaded"; diff --git a/projects/rocprofiler-sdk/source/lib/rocprofiler-sdk-att/tests/dummy_decoder.cpp b/projects/rocprofiler-sdk/source/lib/rocprofiler-sdk-att/tests/dummy_decoder.cpp index fee1ac0055..43071cd5d9 100644 --- a/projects/rocprofiler-sdk/source/lib/rocprofiler-sdk-att/tests/dummy_decoder.cpp +++ b/projects/rocprofiler-sdk/source/lib/rocprofiler-sdk-att/tests/dummy_decoder.cpp @@ -120,6 +120,14 @@ rocprofiler_att_decoder_parse_data(rocprofiler_att_decoder_se_data_callback_t se trace_callback(ROCPROFILER_ATT_DECODER_TYPE_WAVE, 0, waves.data(), waves.size(), userdata); } + { + std::vector vec{}; + att_perfevent_t perf{.events0 = 1, .CU = 1, .bank = 1}; + vec.push_back(perf); + vec.push_back(perf); + trace_callback(ROCPROFILER_ATT_DECODER_TYPE_PERFEVENT, 0, vec.data(), vec.size(), userdata); + } + return ROCPROFILER_ATT_DECODER_STATUS_SUCCESS; }