From b606e3dca7b0cc164231dbc66e16a9f94ec98645 Mon Sep 17 00:00:00 2001 From: Satyanvesh Dittakavi Date: Wed, 9 Oct 2024 18:06:08 +0000 Subject: [PATCH] SWDEV-489570 - Update AQL packet in hipDrvGraphExecMemsetNodeSetParams After setting the new params in hipDrvGraphExecMemsetNodeSetParams, we need to update the AQL packet as well, otherwise during the graph launch it still dispatches the packet which has the original params and not the updated one. Change-Id: Ie49a641ba3f66c8085a29f92d88ac6ea6a1c0534 [ROCm/clr commit: ba2ebb3b99c8fceb5a22eb8e5583ac5c3878c0e9] --- projects/clr/hipamd/src/hip_graph.cpp | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/projects/clr/hipamd/src/hip_graph.cpp b/projects/clr/hipamd/src/hip_graph.cpp index 49ea1fbe94..1c8dc895ae 100644 --- a/projects/clr/hipamd/src/hip_graph.cpp +++ b/projects/clr/hipamd/src/hip_graph.cpp @@ -1703,7 +1703,8 @@ hipError_t hipGraphExecMemsetNodeSetParams(hipGraphExec_t hGraphExec, hipGraphNo if (clonedNode == nullptr) { HIP_RETURN(hipErrorInvalidValue); } - hipError_t status = reinterpret_cast(clonedNode)->SetParams(pNodeParams, true); + hipError_t status = reinterpret_cast(clonedNode) + ->SetParams(pNodeParams, true); if(status != hipSuccess) { HIP_RETURN(status); } @@ -3268,7 +3269,15 @@ hipError_t hipDrvGraphExecMemsetNodeSetParams(hipGraphExec_t hGraphExec, hipGrap if (clonedNode == nullptr) { HIP_RETURN(hipErrorInvalidValue); } - HIP_RETURN(reinterpret_cast(clonedNode)->SetParams(memsetParams, true)); + hipError_t status = reinterpret_cast(clonedNode) + ->SetParams(memsetParams, true); + if(status != hipSuccess) { + HIP_RETURN(status); + } + if (DEBUG_CLR_GRAPH_PACKET_CAPTURE) { + status = reinterpret_cast(hGraphExec)->UpdateAQLPacket(clonedNode); + } + HIP_RETURN(status); } hipError_t hipGraphExecGetFlags(hipGraphExec_t graphExec, unsigned long long* flags) {