CI timeout + line-info in releases (#279)

* Update perfetto args.gn.in

- remove enable_perfetto_tools_trace_to_text (unused)

* core timeout implementation

- requires OMNITRACE_CI=ON
- requires OMNITRACE_CI_TIMEOUT=<sec>
- adds pthread_self and std::this_thread::get_id to thread info
- pthread_create_gotcha stores native handles (pthread_self)

* Testing updates

- improve detection of segfault/failures with PASS_REGEX exists
- add OMNITRACE_CI_TIMEOUT env variable to all tests

* Line-info in releases

- e.g. -g1 + more options to minimize size of debug info

* Fix typo in config exit action message

* OMNITRACE_UNLIKELY around debug/verbose messages

* format fixes

* Overflow tests + capability check

* transpose example update

- link to threads library

* roctracer/rocprofiler update

- in ROCm 5.5.0, cannot include rocprofiler.h and roctracer.h in same file due to conflicting enum defs
- Moved HSA tracing setup/shutdown to component::roctracer

* roctracer update

- fix definition of roctracer::setup when disabled

* Update fork example

- detach threads on main PID
- flush io outputs when printing info

* Update overflow tests

- pass regular expressions
- overflow on PERF_COUNT_SW_CPU_CLOCK event

* fork gotcha update

- use getpid() instead of getppid()

* update fork example

- wait on threads calling fork

* timeout update

- wait on timeout thread to launch before proceeding

[ROCm/rocprofiler-systems commit: 3e2fa69a14]

projects/rocprofiler-systems/source/bin/tests/CMakeLists.txt

@@ -1,8 +1,12 @@
+set(OMNITRACE_ABORT_FAIL_REGEX
+    "### ERROR ###|address of faulting memory reference|exiting with non-zero exit code|terminate called after throwing an instance|calling abort.. in |Exit code: [1-9]"
+    CACHE INTERNAL "Regex to catch abnormal exits when a PASS_REGULAR_EXPRESSION is set")
+
 # adds a ctest for executable
 function(OMNITRACE_ADD_BIN_TEST)
     cmake_parse_arguments(
         TEST
-        "ADD_INVERSE" # options
+        "" # options
         "NAME;TARGET;TIMEOUT;WORKING_DIRECTORY" # single value args
         "ARGS;ENVIRONMENT;LABELS;PROPERTIES;PASS_REGEX;FAIL_REGEX;SKIP_REGEX;DEPENDS;COMMAND" # multiple
         # value args
@@ -33,9 +37,14 @@ function(OMNITRACE_ADD_BIN_TEST)
     endif()
 
     # common
-    list(APPEND TEST_ENVIRONMENT "OMNITRACE_CI=ON" "OMNITRACE_CONFIG_FILE="
-         "OMNITRACE_OUTPUT_PATH=${PROJECT_BINARY_DIR}/omnitrace-tests-output"
-         "TWD=${TEST_WORKING_DIRECTORY}")
+    list(
+        APPEND
+        TEST_ENVIRONMENT
+        "OMNITRACE_CI=ON"
+        "OMNITRACE_CI_TIMEOUT=${TEST_TIMEOUT}"
+        "OMNITRACE_CONFIG_FILE="
+        "OMNITRACE_OUTPUT_PATH=${PROJECT_BINARY_DIR}/omnitrace-tests-output"
+        "TWD=${TEST_WORKING_DIRECTORY}")
     # copy for inverse
     set(TEST_ENVIRONMENT_INV "${TEST_ENVIRONMENT}")
 
@@ -43,6 +52,22 @@ function(OMNITRACE_ADD_BIN_TEST)
     list(APPEND TEST_ENVIRONMENT "OMNITRACE_OUTPUT_PREFIX=${TEST_NAME}/")
     list(APPEND TEST_ENVIRONMENT_INV "OMNITRACE_OUTPUT_PREFIX=${TEST_NAME}-inverse/")
 
+    if(NOT "${TEST_PASS_REGEX}" STREQUAL ""
+       AND NOT "${TEST_FAIL_REGEX}" STREQUAL ""
+       AND NOT "${TEST_FAIL_REGEX}" MATCHES "\\|OMNITRACE_ABORT_FAIL_REGEX")
+        omnitrace_message(
+            FATAL_ERROR
+            "${TEST_NAME} has set pass and fail regexes but fail regex does not include '|OMNITRACE_ABORT_FAIL_REGEX'"
+            )
+    endif()
+
+    if("${TEST_FAIL_REGEX}" STREQUAL "")
+        set(TEST_FAIL_REGEX "(${OMNITRACE_ABORT_FAIL_REGEX})")
+    else()
+        string(REPLACE "|OMNITRACE_ABORT_FAIL_REGEX" "|${OMNITRACE_ABORT_FAIL_REGEX}"
+                       TEST_FAIL_REGEX "${TEST_FAIL_REGEX}")
+    endif()
+
     if(TEST_COMMAND)
         add_test(
             NAME ${TEST_NAME}
@@ -66,32 +91,6 @@ function(OMNITRACE_ADD_BIN_TEST)
                        SKIP_REGULAR_EXPRESSION
                        "${TEST_SKIP_REGEX}"
                        ${TEST_PROPERTIES})
-        if(TEST_ADD_INVERSE)
-            add_test(
-                NAME ${TEST_NAME}-inverse
-                COMMAND ${TEST_COMMAND} ${TEST_ARGS}
-                WORKING_DIRECTORY ${TEST_WORKING_DIRECTORY})
-
-            set_tests_properties(
-                ${TEST_NAME}-inverse
-                PROPERTIES ENVIRONMENT
-                           "${TEST_ENVIRONMENT_INV}"
-                           TIMEOUT
-                           ${TEST_TIMEOUT}
-                           DEPENDS
-                           "${TEST_DEPENDS}"
-                           LABELS
-                           "omnitrace-bin;${TEST_LABELS}"
-                           PASS_REGULAR_EXPRESSION
-                           "${TEST_FAIL_REGEX}"
-                           FAIL_REGULAR_EXPRESSION
-                           "${TEST_PASS_REGEX}"
-                           SKIP_REGULAR_EXPRESSION
-                           "${TEST_SKIP_REGEX}"
-                           WILL_FAIL
-                           ON
-                           ${TEST_PROPERTIES})
-        endif()
     elseif(TARGET ${TEST_TARGET})
         add_test(
             NAME ${TEST_NAME}
@@ -115,32 +114,6 @@ function(OMNITRACE_ADD_BIN_TEST)
                        SKIP_REGULAR_EXPRESSION
                        "${TEST_SKIP_REGEX}"
                        ${TEST_PROPERTIES})
-        if(TEST_ADD_INVERSE)
-            add_test(
-                NAME ${TEST_NAME}-inverse
-                COMMAND $<TARGET_FILE:${TEST_TARGET}> ${TEST_ARGS}
-                WORKING_DIRECTORY ${TEST_WORKING_DIRECTORY})
-
-            set_tests_properties(
-                ${TEST_NAME}-inverse
-                PROPERTIES ENVIRONMENT
-                           "${TEST_ENVIRONMENT_INV}"
-                           TIMEOUT
-                           ${TEST_TIMEOUT}
-                           DEPENDS
-                           "${TEST_DEPENDS}"
-                           LABELS
-                           "omnitrace-bin;${TEST_LABELS}"
-                           PASS_REGULAR_EXPRESSION
-                           "${TEST_FAIL_REGEX}"
-                           FAIL_REGULAR_EXPRESSION
-                           "${TEST_PASS_REGEX}"
-                           SKIP_REGULAR_EXPRESSION
-                           "${TEST_SKIP_REGEX}"
-                           WILL_FAIL
-                           ON
-                           ${TEST_PROPERTIES})
-        endif()
     elseif(OMNITRACE_BUILD_TESTING)
         message(FATAL_ERROR "Error! ${TEST_TARGET} does not exist")
     endif()
@@ -189,10 +162,9 @@ omnitrace_add_bin_test(
     TIMEOUT 60
     PASS_REGEX
         ".*available.json.*available.txt.*available.xml.*excluded.json.*excluded.txt.*excluded.xml.*instrumented.json.*instrumented.txt.*instrumented.xml.*overlapping.json.*overlapping.txt.*overlapping.xml.*"
-    FAIL_REGEX "No such file or directory|not found")
+    FAIL_REGEX "No such file or directory|not found|OMNITRACE_ABORT_FAIL_REGEX")
 
 omnitrace_add_bin_test(
-    ADD_INVERSE
     NAME omnitrace-instrument-simulate-lib
     TARGET omnitrace-instrument
     ARGS --print-available functions -v 2 -- $<TARGET_FILE:omnitrace-user-library>
@@ -243,7 +215,7 @@ omnitrace_add_bin_test(
     LABELS "log"
     TIMEOUT 60
     PASS_REGEX "user.log"
-    FAIL_REGEX "No such file or directory|not found")
+    FAIL_REGEX "No such file or directory|not found|OMNITRACE_ABORT_FAIL_REGEX")
 
 omnitrace_add_bin_test(
     NAME omnitrace-avail-help
@@ -268,7 +240,7 @@ omnitrace_add_bin_test(
     ARGS --all --expand-keys
     LABELS "omnitrace-avail"
     TIMEOUT 45
-    FAIL_REGEX "%[a-zA-Z_]%")
+    FAIL_REGEX "%[a-zA-Z_]%|OMNITRACE_ABORT_FAIL_REGEX")
 
 omnitrace_add_bin_test(
     NAME omnitrace-avail-all-only-available-alphabetical
@@ -309,7 +281,7 @@ omnitrace_add_bin_test(
     TIMEOUT 45
     PASS_REGEX "OMNITRACE_(SETTINGS_DESC|OUTPUT_FILE|OUTPUT_PREFIX)"
     FAIL_REGEX
-        "OMNITRACE_(ADD_SECONDARY|SCIENTIFIC|PRECISION|MEMORY_PRECISION|TIMING_PRECISION)"
+        "OMNITRACE_(ADD_SECONDARY|SCIENTIFIC|PRECISION|MEMORY_PRECISION|TIMING_PRECISION)|OMNITRACE_ABORT_FAIL_REGEX"
     )
 
 omnitrace_add_bin_test(
@@ -320,7 +292,7 @@ omnitrace_add_bin_test(
     TIMEOUT 45
     PASS_REGEX
         "OMNITRACE_(ADD_SECONDARY|SCIENTIFIC|PRECISION|MEMORY_PRECISION|TIMING_PRECISION)"
-    FAIL_REGEX "OMNITRACE_(SETTINGS_DESC|OUTPUT_FILE)")
+    FAIL_REGEX "OMNITRACE_(SETTINGS_DESC|OUTPUT_FILE)|OMNITRACE_ABORT_FAIL_REGEX")
 
 omnitrace_add_bin_test(
     NAME omnitrace-avail-regex-negation
@@ -341,7 +313,7 @@ omnitrace_add_bin_test(
     TIMEOUT 45
     PASS_REGEX
         "ENVIRONMENT VARIABLE,[ \n]+OMNITRACE_THREAD_POOL_SIZE,[ \n]+OMNITRACE_USE_PID,[ \n]+"
-    FAIL_REGEX "OMNITRACE_USE_PERFETTO")
+    FAIL_REGEX "OMNITRACE_USE_PERFETTO|OMNITRACE_ABORT_FAIL_REGEX")
 
 string(REPLACE "+" "\\\+" _AVAIL_CFG_PATH
                "${PROJECT_BINARY_DIR}/omnitrace-tests-output/omnitrace-avail/omnitrace-")