From b683eedab2224d1e213f4d9a322809713c20a10d Mon Sep 17 00:00:00 2001 From: Deepak Mewar Date: Mon, 27 Feb 2023 01:20:42 -0500 Subject: [PATCH] Renamed API amdsmi_get_ecc_error_count to amdsmi_get_gpu_ecc_error_count grep -rli 'amdsmi_get_ecc_error_count' * | xargs -i@ sed -i 's/amdsmi_get_ecc_error_count/amdsmi_get_gpu_ecc_error_count/g' @ Change-Id: I8b7b80278ac47d394f98718d41da5d5a1b833f9c --- example/amd_smi_drm_example.cc | 4 ++-- example/amd_smi_nodrm_example.cc | 4 ++-- include/amd_smi/amdsmi.h | 2 +- py-interface/README.md | 6 +++--- py-interface/__init__.py | 2 +- py-interface/amdsmi_interface.py | 4 ++-- py-interface/amdsmi_wrapper.py | 8 ++++---- src/amd_smi/amd_smi.cc | 2 +- 8 files changed, 16 insertions(+), 16 deletions(-) diff --git a/example/amd_smi_drm_example.cc b/example/amd_smi_drm_example.cc index 4dd523f821..9bc756a7ea 100644 --- a/example/amd_smi_drm_example.cc +++ b/example/amd_smi_drm_example.cc @@ -484,9 +484,9 @@ int main() { // Get ECC error counts amdsmi_error_count_t err_cnt_info = {}; - ret = amdsmi_get_ecc_error_count(processor_handles[j], &err_cnt_info); + ret = amdsmi_get_gpu_ecc_error_count(processor_handles[j], &err_cnt_info); CHK_AMDSMI_RET(ret) - printf(" Output of amdsmi_get_ecc_error_count:\n"); + printf(" Output of amdsmi_get_gpu_ecc_error_count:\n"); printf("\tCorrectable errors: %lu\n", err_cnt_info.correctable_count); printf("\tUncorrectable errors: %lu\n\n", err_cnt_info.uncorrectable_count); diff --git a/example/amd_smi_nodrm_example.cc b/example/amd_smi_nodrm_example.cc index 22fbfc4dae..6a8325f7b1 100644 --- a/example/amd_smi_nodrm_example.cc +++ b/example/amd_smi_nodrm_example.cc @@ -271,9 +271,9 @@ int main() { // Get ECC error counts amdsmi_error_count_t err_cnt_info = {}; - ret = amdsmi_get_ecc_error_count(processor_handles[j], &err_cnt_info); + ret = amdsmi_get_gpu_ecc_error_count(processor_handles[j], &err_cnt_info); CHK_AMDSMI_RET(ret) - printf(" Output of amdsmi_get_ecc_error_count:\n"); + printf(" Output of amdsmi_get_gpu_ecc_error_count:\n"); printf("\tCorrectable errors: %lu\n", err_cnt_info.correctable_count); printf("\tUncorrectable errors: %lu\n\n", err_cnt_info.uncorrectable_count); diff --git a/include/amd_smi/amdsmi.h b/include/amd_smi/amdsmi.h index b24b1b2683..e38d06c4e6 100644 --- a/include/amd_smi/amdsmi.h +++ b/include/amd_smi/amdsmi.h @@ -3878,7 +3878,7 @@ amdsmi_get_process_info(amdsmi_processor_handle processor_handle, amdsmi_process * @return ::amdsmi_status_t | ::AMDSMI_STATUS_SUCCESS on success, non-zero on fail */ amdsmi_status_t -amdsmi_get_ecc_error_count(amdsmi_processor_handle processor_handle, amdsmi_error_count_t *ec); +amdsmi_get_gpu_ecc_error_count(amdsmi_processor_handle processor_handle, amdsmi_error_count_t *ec); /** @} End eccinfo */ diff --git a/py-interface/README.md b/py-interface/README.md index 3867aebcea..6537f9ef1d 100644 --- a/py-interface/README.md +++ b/py-interface/README.md @@ -875,7 +875,7 @@ except AmdSmiException as e: print(e) ``` -## amdsmi_get_ecc_error_count +## amdsmi_get_gpu_ecc_error_count Description: Returns the ECC error count for the given GPU Input parameters: @@ -889,7 +889,7 @@ Field | Description `correctable_count`| Correctable ECC error count `uncorrectable_count`| Uncorrectable ECC error count -Exceptions that can be thrown by `amdsmi_get_ecc_error_count` function: +Exceptions that can be thrown by `amdsmi_get_gpu_ecc_error_count` function: * `AmdSmiLibraryException` * `AmdSmiRetryException` * `AmdSmiParameterException` @@ -902,7 +902,7 @@ try: print("No GPUs on machine") else: for device in devices: - ecc_error_count = amdsmi_get_ecc_error_count(device) + ecc_error_count = amdsmi_get_gpu_ecc_error_count(device) print(ecc_error_count["correctable_count"]) print(ecc_error_count["uncorrectable_count"]) except AmdSmiException as e: diff --git a/py-interface/__init__.py b/py-interface/__init__.py index b1fb20d1ef..2db2cf0d66 100644 --- a/py-interface/__init__.py +++ b/py-interface/__init__.py @@ -63,7 +63,7 @@ from .amdsmi_interface import amdsmi_get_process_list from .amdsmi_interface import amdsmi_get_process_info # # ECC Error Information -from .amdsmi_interface import amdsmi_get_ecc_error_count +from .amdsmi_interface import amdsmi_get_gpu_ecc_error_count # # Board Information from .amdsmi_interface import amdsmi_get_gpu_board_info diff --git a/py-interface/amdsmi_interface.py b/py-interface/amdsmi_interface.py index cb1b8a7d1b..b99feeaeed 100644 --- a/py-interface/amdsmi_interface.py +++ b/py-interface/amdsmi_interface.py @@ -779,7 +779,7 @@ def amdsmi_get_gpu_target_frequency_range( } -def amdsmi_get_ecc_error_count( +def amdsmi_get_gpu_ecc_error_count( processor_handle: amdsmi_wrapper.amdsmi_processor_handle, ) -> Dict[str, Any]: if not isinstance(processor_handle, amdsmi_wrapper.amdsmi_processor_handle): @@ -789,7 +789,7 @@ def amdsmi_get_ecc_error_count( error_count = amdsmi_wrapper.amdsmi_error_count_t() _check_res( - amdsmi_wrapper.amdsmi_get_ecc_error_count( + amdsmi_wrapper.amdsmi_get_gpu_ecc_error_count( processor_handle, ctypes.byref(error_count) ) ) diff --git a/py-interface/amdsmi_wrapper.py b/py-interface/amdsmi_wrapper.py index c7cec32ee1..0335975b9d 100644 --- a/py-interface/amdsmi_wrapper.py +++ b/py-interface/amdsmi_wrapper.py @@ -1715,9 +1715,9 @@ amdsmi_get_process_list.argtypes = [amdsmi_processor_handle, ctypes.POINTER(ctyp amdsmi_get_process_info = _libraries['libamd_smi.so'].amdsmi_get_process_info amdsmi_get_process_info.restype = amdsmi_status_t amdsmi_get_process_info.argtypes = [amdsmi_processor_handle, amdsmi_process_handle, ctypes.POINTER(struct_c__SA_amdsmi_proc_info_t)] -amdsmi_get_ecc_error_count = _libraries['libamd_smi.so'].amdsmi_get_ecc_error_count -amdsmi_get_ecc_error_count.restype = amdsmi_status_t -amdsmi_get_ecc_error_count.argtypes = [amdsmi_processor_handle, ctypes.POINTER(struct_c__SA_amdsmi_error_count_t)] +amdsmi_get_gpu_ecc_error_count = _libraries['libamd_smi.so'].amdsmi_get_gpu_ecc_error_count +amdsmi_get_gpu_ecc_error_count.restype = amdsmi_status_t +amdsmi_get_gpu_ecc_error_count.argtypes = [amdsmi_processor_handle, ctypes.POINTER(struct_c__SA_amdsmi_error_count_t)] __all__ = \ ['AMDSMI_CNTR_CMD_START', 'AMDSMI_CNTR_CMD_STOP', 'AMDSMI_COARSE_GRAIN_GFX_ACTIVITY', @@ -1901,7 +1901,7 @@ __all__ = \ 'amdsmi_get_compute_process_info_by_pid', 'amdsmi_get_gpu_device_bdf', 'amdsmi_get_processor_handle_from_bdf', 'amdsmi_get_processor_handles', 'amdsmi_get_processor_type', 'amdsmi_get_gpu_device_uuid', - 'amdsmi_get_gpu_driver_version', 'amdsmi_get_ecc_error_count', + 'amdsmi_get_gpu_driver_version', 'amdsmi_get_gpu_ecc_error_count', 'amdsmi_get_event_notification', 'amdsmi_get_func_iter_value', 'amdsmi_get_fw_info', 'amdsmi_get_gpu_activity', 'amdsmi_get_minmax_bandwidth', 'amdsmi_get_pcie_link_caps', diff --git a/src/amd_smi/amd_smi.cc b/src/amd_smi/amd_smi.cc index 7f8d103ea8..f47cf3c86b 100644 --- a/src/amd_smi/amd_smi.cc +++ b/src/amd_smi/amd_smi.cc @@ -1598,7 +1598,7 @@ amdsmi_get_gpu_bad_page_info(amdsmi_processor_handle processor_handle, uint32_t } amdsmi_status_t -amdsmi_get_ecc_error_count(amdsmi_processor_handle processor_handle, amdsmi_error_count_t *ec) { +amdsmi_get_gpu_ecc_error_count(amdsmi_processor_handle processor_handle, amdsmi_error_count_t *ec) { AMDSMI_CHECK_INIT(); if (ec == nullptr) {