diff --git a/.gitignore b/.gitignore index 4abf0e47d9..55abee102c 100644 --- a/.gitignore +++ b/.gitignore @@ -12,3 +12,6 @@ python_smi_tools/rsmiBindings.py # Build directory build/ + +# CMake cache +.cache/ diff --git a/python_smi_tools/rocm_smi.py b/python_smi_tools/rocm_smi.py index a478d2f8f6..431e796b38 100755 --- a/python_smi_tools/rocm_smi.py +++ b/python_smi_tools/rocm_smi.py @@ -537,7 +537,7 @@ def printEventList(device, delay, eventList): data = rsmi_evt_notification_data_t(1) rocmsmi.rsmi_event_notification_get(delay, byref(num_elements), byref(data)) if len(data.message) > 0: - print2DArray([['\rGPU[%d]:\t' % (device), ctime().split()[3], notification_type_names[data.event.value - 1], + print2DArray([['\rGPU[%d]:\t' % (data.dv_ind), ctime().split()[3], notification_type_names[data.event.value - 1], data.message.decode('utf8') + '\r']]) def printLog(device, metricName, value=None, extraSpace=False): diff --git a/src/rocm_smi_device.cc b/src/rocm_smi_device.cc index 18c96b7f13..554b8c0eb8 100755 --- a/src/rocm_smi_device.cc +++ b/src/rocm_smi_device.cc @@ -379,7 +379,8 @@ static const std::map kDevFuncDependsMap = { {"rsmi_dev_name_get", {{kDevVendorIDFName, kDevDevIDFName}, {}}}, {"rsmi_dev_sku_get", {{kDevDevProdNumFName}, {}}}, - {"rsmi_dev_brand_get", {{kDevVendorIDFName}, {}}}, + {"rsmi_dev_brand_get", {{kDevVendorIDFName, + kDevVBiosVerFName}, {}}}, {"rsmi_dev_vendor_name_get", {{kDevVendorIDFName}, {}}}, {"rsmi_dev_serial_number_get", {{kDevSerialNumberFName}, {}}}, {"rsmi_dev_subsystem_id_get", {{kDevSubSysDevIDFName}, {}}}, diff --git a/tests/rocm_smi_test/functional/id_info_read.cc b/tests/rocm_smi_test/functional/id_info_read.cc index 5c7eea1256..11828feb85 100755 --- a/tests/rocm_smi_test/functional/id_info_read.cc +++ b/tests/rocm_smi_test/functional/id_info_read.cc @@ -162,7 +162,7 @@ void TestIdInfoRead::Run(void) { IF_VERB(STANDARD) { std::cout << "\t**Device Vram Vendor name: " << buffer << std::endl; } - err = rsmi_dev_brand_get(i, nullptr, kBufferLen); + err = rsmi_dev_vram_vendor_get(i, nullptr, kBufferLen); ASSERT_EQ(err, RSMI_STATUS_INVALID_ARGS); } err = rsmi_dev_vendor_id_get(i, &id); diff --git a/tests/rocm_smi_test/functional/sys_info_read.cc b/tests/rocm_smi_test/functional/sys_info_read.cc index 14d1977676..dcff82aa84 100755 --- a/tests/rocm_smi_test/functional/sys_info_read.cc +++ b/tests/rocm_smi_test/functional/sys_info_read.cc @@ -105,7 +105,7 @@ void TestSysInfoRead::Run(void) { err = rsmi_dev_vbios_version_get(i, buffer, 80); if (err != RSMI_STATUS_SUCCESS) { - if (err == RSMI_STATUS_FILE_ERROR) { + if ((err == RSMI_STATUS_FILE_ERROR) || (err == RSMI_STATUS_NOT_SUPPORTED)) { IF_VERB(STANDARD) { std::cout << "\t**VBIOS read: Not supported on this machine" << std::endl;