Substitute pow2bin allocator with a dlmalloc based allocator (#71)

* Add dlmalloc_strat allocator strategy
 - Use mspace variant to ease encapsulation
 - Make pow2bins and dlmalloc cmake selectable
* Add unit tester for dlmalloc, rework single_heap, pow2bins unit testers
accordingly
 - add dlmalloc get_used/get_avail, and have all strats allocators also have a get_used
 - Rework memallocator unit tests: bin size is per strat, alignment is verified in singleheap
* bugfix: dlmalloc exposed that the pingpong test would write past end of
allocation with -w 32
* iostream leakage/mixed usage of cerr and fprintf(stderr

---------

Signed-off-by: Aurelien Bouteiller <aurelien.bouteiller@amd.com>

tests/unit_tests/pow2_bins_gtest.cpp

@@ -26,35 +26,47 @@
 
 using namespace rocshmem;
 
+TEST_F(Pow2BinsTestFixture, used_0_bytes) {
+  ASSERT_EQ(strat_.get_used(), 0);
+}
+
 TEST_F(Pow2BinsTestFixture, alloc_0_bytes) {
   char* c_ptr{nullptr};
   size_t size{0};
+  size_t expected_used{0};
   strat_.alloc(&c_ptr, size);
   ASSERT_EQ(c_ptr, nullptr);
+  ASSERT_EQ(strat_.get_used(), expected_used);
 }
 
 TEST_F(Pow2BinsTestFixture, alloc_1_byte) {
   char* c_ptr{nullptr};
   size_t size{1};
+  size_t align_size{ALIGNMENT * (1 + (size - 1) / ALIGNMENT)};
   strat_.alloc(&c_ptr, size);
   ASSERT_NE(c_ptr, nullptr);
 
   size_t min_size{256};
+  ASSERT_LE(align_size, 256); // test fixture won't work for larger values
   auto bins{strat_.get_bins()};
   auto bin{(*bins)[min_size]};
   ASSERT_EQ(bin.size(), 1);
+  ASSERT_EQ(strat_.get_used(), align_size);
 }
 
 TEST_F(Pow2BinsTestFixture, alloc_128_bytes) {
   char* c_ptr{nullptr};
   size_t size{128};
+  size_t align_size{ALIGNMENT * (1 + (size - 1) / ALIGNMENT)};
   strat_.alloc(&c_ptr, size);
   ASSERT_NE(c_ptr, nullptr);
 
   size_t min_size{256};
+  ASSERT_LE(align_size, 256);
   auto bins{strat_.get_bins()};
   auto bin{(*bins)[min_size]};
   ASSERT_EQ(bin.size(), 1);
+  ASSERT_EQ(strat_.get_used(), align_size);
 }
 
 TEST_F(Pow2BinsTestFixture, alloc_256_bytes) {
@@ -66,6 +78,7 @@ TEST_F(Pow2BinsTestFixture, alloc_256_bytes) {
   auto bins{strat_.get_bins()};
   auto bin{(*bins)[size]};
   ASSERT_EQ(bin.size(), 1);
+  ASSERT_EQ(strat_.get_used(), size);
 }
 
 TEST_F(Pow2BinsTestFixture, alloc_512_bytes) {
@@ -77,6 +90,7 @@ TEST_F(Pow2BinsTestFixture, alloc_512_bytes) {
   auto bins{strat_.get_bins()};
   auto bin{(*bins)[size]};
   ASSERT_EQ(bin.size(), 1);
+  ASSERT_EQ(strat_.get_used(), size);
 }
 
 TEST_F(Pow2BinsTestFixture, alloc_513_bytes) {
@@ -89,6 +103,20 @@ TEST_F(Pow2BinsTestFixture, alloc_513_bytes) {
   auto bins{strat_.get_bins()};
   auto bin{(*bins)[min_size]};
   ASSERT_EQ(bin.size(), 1);
+  ASSERT_EQ(strat_.get_used(), min_size);
+}
+
+TEST_F(Pow2BinsTestFixture, alloc_4095_bytes) {
+  char* c_ptr{nullptr};
+  size_t size{4095};
+  strat_.alloc(&c_ptr, size);
+  ASSERT_NE(c_ptr, nullptr);
+
+  size_t min_size{4096};
+  auto bins{strat_.get_bins()};
+  auto bin{(*bins)[min_size]};
+  ASSERT_EQ(bin.size(), 1);
+  ASSERT_EQ(strat_.get_used(), min_size);
 }
 
 TEST_F(Pow2BinsTestFixture, alloc_4KB) {
@@ -100,6 +128,20 @@ TEST_F(Pow2BinsTestFixture, alloc_4KB) {
   auto bins{strat_.get_bins()};
   auto bin{(*bins)[size]};
   ASSERT_EQ(bin.size(), 1);
+  ASSERT_EQ(strat_.get_used(), size);
+}
+
+TEST_F(Pow2BinsTestFixture, alloc_4097_bytes) {
+  char* c_ptr{nullptr};
+  size_t size{4097};
+  strat_.alloc(&c_ptr, size);
+  ASSERT_NE(c_ptr, nullptr);
+
+  size_t min_size{8192};
+  auto bins{strat_.get_bins()};
+  auto bin{(*bins)[min_size]};
+  ASSERT_EQ(bin.size(), 1);
+  ASSERT_EQ(strat_.get_used(), min_size);
 }
 
 TEST_F(Pow2BinsTestFixture, alloc_128KB) {
@@ -111,6 +153,7 @@ TEST_F(Pow2BinsTestFixture, alloc_128KB) {
   auto bins{strat_.get_bins()};
   auto bin{(*bins)[size]};
   ASSERT_EQ(bin.size(), 1);
+  ASSERT_EQ(strat_.get_used(), size);
 }
 
 TEST_F(Pow2BinsTestFixture, alloc_1GB) {
@@ -122,6 +165,7 @@ TEST_F(Pow2BinsTestFixture, alloc_1GB) {
   auto bins{strat_.get_bins()};
   auto bin{(*bins)[size]};
   ASSERT_EQ(bin.size(), 0);
+  ASSERT_EQ(strat_.get_used(), size);
 }
 
 TEST_F(Pow2BinsTestFixture, alloc_256_bytes_X2_free_256_bytes_X2) {
@@ -136,11 +180,13 @@ TEST_F(Pow2BinsTestFixture, alloc_256_bytes_X2_free_256_bytes_X2) {
   auto bins{strat_.get_bins()};
   auto& bin{(*bins)[size]};
   ASSERT_EQ(bin.size(), 0);
+  ASSERT_EQ(strat_.get_used(), 2 * size);
 
   strat_.free(c_ptr_1);
   strat_.free(c_ptr_2);
 
   ASSERT_EQ(bin.size(), 2);
+  ASSERT_EQ(strat_.get_used(), 0);
 }
 
 TEST_F(Pow2BinsTestFixture, alloc_1GB_free_1GB) {
@@ -152,8 +198,10 @@ TEST_F(Pow2BinsTestFixture, alloc_1GB_free_1GB) {
   auto bins{strat_.get_bins()};
   auto& bin{(*bins)[size]};
   ASSERT_EQ(bin.size(), 0);
+  ASSERT_EQ(strat_.get_used(), size);
 
   strat_.free(c_ptr);
 
   ASSERT_EQ(bin.size(), 1);
+  ASSERT_EQ(strat_.get_used(), 0);
 }