This introduces LipoProteinLipase (lpl), a simple tool for creating fat binaries. It represents a direct replacement of the creaky hccgenco.sh script, which had various issues. The format it uses is that of a code object bundle, generated by the Clang Offload Bundler. The output is always suffixed with the ".adipose" extension. It is shared with HCC. The hipcc script and associated tests are modified to use lpl. Help can be obtained by invoking lpl --help. A more computer-sciency / corporate friendly name is likely to be beneficial, which is a reason for choosing easily searchable/replaceable names such as lpl or adipose.

src/program_state.cpp

@@ -30,34 +30,16 @@ using namespace ELFIO;
 using namespace hip_impl;
 using namespace std;
 
-namespace std
-{
-    template<>
-    struct hash<hsa_isa_t> {
-        size_t operator()(hsa_isa_t x) const
-        {
-            return hash<decltype(x.handle)>{}(x.handle);
-        }
-    };
-}
-
-inline
-constexpr
-bool operator==(hsa_isa_t x, hsa_isa_t y)
-{
-    return x.handle == y.handle;
-}
-
 namespace
 {
      struct Symbol {
-        std::string name;
+        string name;
         ELFIO::Elf64_Addr value = 0;
-        ELFIO::Elf_Xword size = 0;
-        ELFIO::Elf_Half sect_idx = 0;
-        std::uint8_t bind = 0;
-        std::uint8_t type = 0;
-        std::uint8_t other = 0;
+        Elf_Xword size = 0;
+        Elf_Half sect_idx = 0;
+        uint8_t bind = 0;
+        uint8_t type = 0;
+        uint8_t other = 0;
     };
 
     inline
@@ -185,7 +167,7 @@ namespace
         }
     }
 
-    vector<uint8_t> code_object_blob_for_process()
+    vector<char> code_object_blob_for_process()
     {
         static constexpr const char self[] = "/proc/self/exe";
         static constexpr const char kernel_section[] = ".kernel";
@@ -200,7 +182,7 @@ namespace
             return x->get_name() == kernel_section;
         });
 
-        vector<uint8_t> r;
+        vector<char> r;
         if (kernels) {
             r.insert(
                 r.end(),
@@ -211,13 +193,13 @@ namespace
         return r;
     }
 
-    const unordered_map<hsa_isa_t, vector<vector<uint8_t>>>& code_object_blobs()
+    const unordered_map<hsa_isa_t, vector<vector<char>>>& code_object_blobs()
     {
-        static unordered_map<hsa_isa_t, vector<vector<uint8_t>>> r;
+        static unordered_map<hsa_isa_t, vector<vector<char>>> r;
         static once_flag f;
 
         call_once(f, []() {
-            static vector<vector<uint8_t>> blobs{
+            static vector<vector<char>> blobs{
                 code_object_blob_for_process()};
 
             dl_iterate_phdr([](dl_phdr_info* info, std::size_t, void*) {
@@ -481,7 +463,7 @@ namespace hip_impl
 
         const auto code_object_dynsym =
             find_section_if(reader, [](const ELFIO::section* x) {
-                    return x->get_type() == SHT_DYNSYM;
+                return x->get_type() == SHT_DYNSYM;
             });
 
         associate_code_object_symbols_with_host_allocation(