From 0602fc6124cc8e765578432e0f28227bfb90d7fe Mon Sep 17 00:00:00 2001 From: Chris Kitching Date: Thu, 19 Oct 2017 14:11:15 +0100 Subject: [PATCH 1/2] Allow user-provided -std=* argument to override the default This means any user-provided -std=* argument overrides this one, allowing use of newer standards. [ROCm/hip commit: 742526706bffc00ca7c6b465ac3bfe5f89d084f7] --- projects/hip/hipify-clang/src/Cuda2Hip.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/projects/hip/hipify-clang/src/Cuda2Hip.cpp b/projects/hip/hipify-clang/src/Cuda2Hip.cpp index f34cc77928..e31a7c4480 100644 --- a/projects/hip/hipify-clang/src/Cuda2Hip.cpp +++ b/projects/hip/hipify-clang/src/Cuda2Hip.cpp @@ -4281,7 +4281,9 @@ int main(int argc, const char **argv) { compilationStages.push_back("--cuda-host-only"); Tool.appendArgumentsAdjuster(getInsertArgumentAdjuster(compilationStages[0], ArgumentInsertPosition::BEGIN)); - Tool.appendArgumentsAdjuster(getInsertArgumentAdjuster("-std=c++11")); + + // Ensure at least c++11 is used. + Tool.appendArgumentsAdjuster(getInsertArgumentAdjuster("-std=c++11", ArgumentInsertPosition::BEGIN)); #if defined(HIPIFY_CLANG_RES) Tool.appendArgumentsAdjuster(getInsertArgumentAdjuster("-resource-dir=" HIPIFY_CLANG_RES)); #endif From 9cd878f5c7c3f222ec4749244d0221195928f95e Mon Sep 17 00:00:00 2001 From: Chris Kitching Date: Thu, 19 Oct 2017 13:04:00 +0100 Subject: [PATCH 2/2] Inline a redundant std::vector Looks like a partial refactor..? [ROCm/hip commit: 4ba2b2e5b819eb95257a2c7ce4767c265a22f824] --- projects/hip/hipify-clang/src/Cuda2Hip.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/projects/hip/hipify-clang/src/Cuda2Hip.cpp b/projects/hip/hipify-clang/src/Cuda2Hip.cpp index e31a7c4480..907e78e54f 100644 --- a/projects/hip/hipify-clang/src/Cuda2Hip.cpp +++ b/projects/hip/hipify-clang/src/Cuda2Hip.cpp @@ -4277,10 +4277,8 @@ int main(int argc, const char **argv) { addAllMatchers(Finder, &Callback); auto action = newFrontendActionFactory(&Finder, &PPCallbacks); - std::vector compilationStages; - compilationStages.push_back("--cuda-host-only"); - Tool.appendArgumentsAdjuster(getInsertArgumentAdjuster(compilationStages[0], ArgumentInsertPosition::BEGIN)); + Tool.appendArgumentsAdjuster(getInsertArgumentAdjuster("--cuda-host-only", ArgumentInsertPosition::BEGIN)); // Ensure at least c++11 is used. Tool.appendArgumentsAdjuster(getInsertArgumentAdjuster("-std=c++11", ArgumentInsertPosition::BEGIN));