Put cached perfetto traces as default one (#2138)

* Put cached perfetto traces as default one

* Improve cached data and perfetto traces in order to be more aligned with E2E tests

* Addressing PR comments and findings

* Force early instrumentation bundle instantiation

* Sync-up insturumented containers with thread growth data

* Revert ompvv number of host threads to default 8

* Fixed counter track namings for amd-smi

* AIPROFSYST-34 [rocprof-sys] Update documentation describing newly introduced changes to default tracing mechanism

projects/rocprofiler-systems/source/bin/rocprof-sys-avail/generate_config.cpp

@@ -340,10 +340,11 @@ generate_config(std::string _config_file, const std::set<std::string>& _config_f
                 if(_romni && !_lomni) return false;
                 for(const auto* itr :
                     { "ROCPROFSYS_CONFIG", "ROCPROFSYS_MODE", "ROCPROFSYS_TRACE_CACHED",
-                      "ROCPROFSYS_TRACE", "ROCPROFSYS_PROFILE", "ROCPROFSYS_USE_SAMPLING",
-                      "ROCPROFSYS_USE_PROCESS_SAMPLING", "ROCPROFSYS_USE_ROCM",
-                      "ROCPROFSYS_USE_AMD_SMI", "ROCPROFSYS_USE_KOKKOSP",
-                      "ROCPROFSYS_USE_OMPT", "ROCPROFSYS_USE", "ROCPROFSYS_OUTPUT" })
+                      "ROCPROFSYS_TRACE_LEGACY", "ROCPROFSYS_PROFILE",
+                      "ROCPROFSYS_USE_SAMPLING", "ROCPROFSYS_USE_PROCESS_SAMPLING",
+                      "ROCPROFSYS_USE_ROCM", "ROCPROFSYS_USE_AMD_SMI",
+                      "ROCPROFSYS_USE_KOKKOSP", "ROCPROFSYS_USE_OMPT", "ROCPROFSYS_USE",
+                      "ROCPROFSYS_OUTPUT" })
                 {
                     if(_lhs->get_env_name().find(itr) == 0 &&
                        _rhs->get_env_name().find(itr) != 0)

projects/rocprofiler-systems/source/bin/rocprof-sys-causal/impl.cpp

@@ -189,7 +189,7 @@ get_initial_environment()
     update_env(_env, "ROCPROFSYS_TRACE_CACHED", false);
     update_env(_env, "ROCPROFSYS_PROFILE", false);
     update_env(_env, "ROCPROFSYS_USE_PROCESS_SAMPLING", false);
-    update_env(_env, "ROCPROFSYS_TRACE", false);
+    update_env(_env, "ROCPROFSYS_TRACE_LEGACY", false);
     update_env(_env, "ROCPROFSYS_THREAD_POOL_SIZE",
                get_env<int>("ROCPROFSYS_THREAD_POOL_SIZE", 0));
     update_env(_env, "ROCPROFSYS_LAUNCHER", "rocprof-sys-causal");

projects/rocprofiler-systems/source/bin/rocprof-sys-sample/impl.cpp

@@ -339,20 +339,23 @@ parse_args(int argc, char** argv, std::vector<char*>& _env)
                                                original_envs);
         });
     parser
-        .add_argument({ "-T", "--trace" }, "Generate a detailed trace (perfetto output)")
+        .add_argument(
+            { "-T", "--trace" },
+            "Generate a detailed trace with deferred trace generation (perfetto output)")
         .max_count(1)
         .action([&](parser_t& p) {
-            rocprofsys::common::update_env(_env, "ROCPROFSYS_TRACE", p.get<bool>("trace"),
-                                           update_mode::REPLACE, ":", updated_envs,
-                                           original_envs);
+            rocprofsys::common::update_env(_env, "ROCPROFSYS_TRACE_CACHED",
+                                           p.get<bool>("trace"), update_mode::REPLACE,
+                                           ":", updated_envs, original_envs);
         });
     parser
-        .add_argument({ "--trace-cached" },
-                      "Generate a detailed trace (perfetto output) from cached data ")
+        .add_argument(
+            { "-L", "--trace-legacy" },
+            "Generate a detailed trace with direct mode (perfetto output, legacy)")
         .max_count(1)
         .action([&](parser_t& p) {
             rocprofsys::common::update_env(
-                _env, "ROCPROFSYS_TRACE_CACHED", p.get<bool>("trace-cached"),
+                _env, "ROCPROFSYS_TRACE_LEGACY", p.get<bool>("trace-legacy"),
                 update_mode::REPLACE, ":", updated_envs, original_envs);
         });
     parser