From bf01732e7f71622d2f16addbb8cc46530b31fe0f Mon Sep 17 00:00:00 2001 From: "Ramakrishnan, Ranjith" Date: Thu, 20 Feb 2025 21:29:41 +0530 Subject: [PATCH] SWDEV-514558 - Use RPM_INSTALL_PREFIX variable rather than hard coded install prefix paths in RPM post/prerm scripts (#114) --- RPM/amd-smi-lib-tests/preun.in | 18 +++++++++--------- RPM/amd-smi-lib/preun.in | 18 +++++++++--------- RPM/post.in | 6 +++--- RPM/preun.in | 18 +++++++++--------- 4 files changed, 30 insertions(+), 30 deletions(-) diff --git a/RPM/amd-smi-lib-tests/preun.in b/RPM/amd-smi-lib-tests/preun.in index 70013da540..8892c2464c 100755 --- a/RPM/amd-smi-lib-tests/preun.in +++ b/RPM/amd-smi-lib-tests/preun.in @@ -2,16 +2,16 @@ rm_leftovers() { # remove pyc files generated by python - rm -rf "@CPACK_PACKAGING_INSTALL_PREFIX@/@CMAKE_INSTALL_LIBEXECDIR@/amdsmi_cli/__pycache__" - rm -rf "@CPACK_PACKAGING_INSTALL_PREFIX@/@SHARE_INSTALL_PREFIX@/amdsmi/__pycache__" + rm -rf "$RPM_INSTALL_PREFIX0/@CMAKE_INSTALL_LIBEXECDIR@/amdsmi_cli/__pycache__" + rm -rf "$RPM_INSTALL_PREFIX0/@SHARE_INSTALL_PREFIX@/amdsmi/__pycache__" # remove build and egg files - rm -rf "@CPACK_PACKAGING_INSTALL_PREFIX@/@SHARE_INSTALL_PREFIX@/amdsmi.egg-info" - rm -rf "@CPACK_PACKAGING_INSTALL_PREFIX@/@SHARE_INSTALL_PREFIX@/build" + rm -rf "$RPM_INSTALL_PREFIX0/@SHARE_INSTALL_PREFIX@/amdsmi.egg-info" + rm -rf "$RPM_INSTALL_PREFIX0/@SHARE_INSTALL_PREFIX@/build" # remove leftover doc files - if test -e "@CPACK_PACKAGING_INSTALL_PREFIX@/@SHARE_INSTALL_PREFIX@/../doc/amd_smi*"; then - rm -rf "@CPACK_PACKAGING_INSTALL_PREFIX@/@SHARE_INSTALL_PREFIX@/../doc/amd_smi*" + if test -e "$RPM_INSTALL_PREFIX0/@SHARE_INSTALL_PREFIX@/../doc/amd_smi*"; then + rm -rf "$RPM_INSTALL_PREFIX0/@SHARE_INSTALL_PREFIX@/../doc/amd_smi*" fi } @@ -22,8 +22,8 @@ rm_logFolder() { rm_rocm_tests_dir(){ - if [ -d "@CPACK_PACKAGING_INSTALL_PREFIX@/share/amd_smi/tests/" ]; then - rm -rf "@CPACK_PACKAGING_INSTALL_PREFIX@/share/amd_smi/tests/" + if [ -d "$RPM_INSTALL_PREFIX0/share/amd_smi/tests/" ]; then + rm -rf "$RPM_INSTALL_PREFIX0/share/amd_smi/tests/" echo "Removed ROCm tests directory." fi } @@ -83,7 +83,7 @@ rm_python_lib() { if [ "$1" -le 1 ]; then # perform the below actions for rpm remove($1=0) or upgrade($1=1) operations # remove old gpuv-smi symlink - rm -f @CPACK_PACKAGING_INSTALL_PREFIX@/bin/gpuv-smi &> /dev/null + rm -f $RPM_INSTALL_PREFIX0/bin/gpuv-smi &> /dev/null echo "Removing AMDSMI Lib Tests Packages..." rm_ldconfig echo " ldconfig removed" diff --git a/RPM/amd-smi-lib/preun.in b/RPM/amd-smi-lib/preun.in index d3f257e0a2..2879144be5 100755 --- a/RPM/amd-smi-lib/preun.in +++ b/RPM/amd-smi-lib/preun.in @@ -2,16 +2,16 @@ rm_leftovers() { # remove pyc files generated by python - rm -rf "@CPACK_PACKAGING_INSTALL_PREFIX@/@CMAKE_INSTALL_LIBEXECDIR@/amdsmi_cli/__pycache__" - rm -rf "@CPACK_PACKAGING_INSTALL_PREFIX@/@SHARE_INSTALL_PREFIX@/amdsmi/__pycache__" + rm -rf "$RPM_INSTALL_PREFIX0/@CMAKE_INSTALL_LIBEXECDIR@/amdsmi_cli/__pycache__" + rm -rf "$RPM_INSTALL_PREFIX0/@SHARE_INSTALL_PREFIX@/amdsmi/__pycache__" # remove build and egg files - rm -rf "@CPACK_PACKAGING_INSTALL_PREFIX@/@SHARE_INSTALL_PREFIX@/amdsmi.egg-info" - rm -rf "@CPACK_PACKAGING_INSTALL_PREFIX@/@SHARE_INSTALL_PREFIX@/build" + rm -rf "$RPM_INSTALL_PREFIX0/@SHARE_INSTALL_PREFIX@/amdsmi.egg-info" + rm -rf "$RPM_INSTALL_PREFIX0/@SHARE_INSTALL_PREFIX@/build" # remove leftover doc files - if test -e "@CPACK_PACKAGING_INSTALL_PREFIX@/@SHARE_INSTALL_PREFIX@/../doc/amd_smi*"; then - rm -rf "@CPACK_PACKAGING_INSTALL_PREFIX@/@SHARE_INSTALL_PREFIX@/../doc/amd_smi*" + if test -e "$RPM_INSTALL_PREFIX0/@SHARE_INSTALL_PREFIX@/../doc/amd_smi*"; then + rm -rf "$RPM_INSTALL_PREFIX0/@SHARE_INSTALL_PREFIX@/../doc/amd_smi*" fi } @@ -22,8 +22,8 @@ rm_logFolder() { rm_rocm_tests_dir(){ - if [ -d "@CPACK_PACKAGING_INSTALL_PREFIX@/share/amd_smi/tests/" ]; then - rm -rf "@CPACK_PACKAGING_INSTALL_PREFIX@/share/amd_smi/tests/" + if [ -d "$RPM_INSTALL_PREFIX0/share/amd_smi/tests/" ]; then + rm -rf "$RPM_INSTALL_PREFIX0/share/amd_smi/tests/" echo "Removed ROCm tests directory." fi } @@ -83,7 +83,7 @@ rm_python_lib() { if [ "$1" -le 1 ]; then # perform the below actions for rpm remove($1=0) or upgrade($1=1) operations # remove old gpuv-smi symlink - rm -f @CPACK_PACKAGING_INSTALL_PREFIX@/bin/gpuv-smi &> /dev/null + rm -f $RPM_INSTALL_PREFIX0/bin/gpuv-smi &> /dev/null echo "Removing AMDSMI Lib Packages..." rm_python_lib rm_ldconfig diff --git a/RPM/post.in b/RPM/post.in index 05fd0cc11a..df89245d2a 100755 --- a/RPM/post.in +++ b/RPM/post.in @@ -103,7 +103,7 @@ EOF do_ldconfig() { # left-hand term originates from ENABLE_LDCONFIG = ON/OFF at package build if [ "@ENABLE_LDCONFIG@" == "ON" ]; then - echo @CPACK_PACKAGING_INSTALL_PREFIX@/@CMAKE_INSTALL_LIBDIR@ > /etc/ld.so.conf.d/x86_64-libamd_smi_lib.conf + echo $RPM_INSTALL_PREFIX0/@CMAKE_INSTALL_LIBDIR@ > /etc/ld.so.conf.d/x86_64-libamd_smi_lib.conf ldconfig fi } @@ -157,8 +157,8 @@ do_install_amdsmi_python_lib() { return fi - # install python library at @CPACK_PACKAGING_INSTALL_PREFIX@/@SHARE_INSTALL_PREFIX@/amdsmi - local python_lib_path=@CPACK_PACKAGING_INSTALL_PREFIX@/@SHARE_INSTALL_PREFIX@ + # install python library at $RPM_INSTALL_PREFIX0/@SHARE_INSTALL_PREFIX@/amdsmi + local python_lib_path=$RPM_INSTALL_PREFIX0/@SHARE_INSTALL_PREFIX@ local amdsmi_python_lib_path="$python_lib_path" local amdsmi_setup_py_path="$python_lib_path/setup.py" diff --git a/RPM/preun.in b/RPM/preun.in index 43e58c93f3..d18d0246ae 100755 --- a/RPM/preun.in +++ b/RPM/preun.in @@ -2,16 +2,16 @@ rm_leftovers() { # remove pyc files generated by python - rm -rf "@CPACK_PACKAGING_INSTALL_PREFIX@/@CMAKE_INSTALL_LIBEXECDIR@/amdsmi_cli/__pycache__" - rm -rf "@CPACK_PACKAGING_INSTALL_PREFIX@/@SHARE_INSTALL_PREFIX@/amdsmi/__pycache__" + rm -rf "$RPM_INSTALL_PREFIX0/@CMAKE_INSTALL_LIBEXECDIR@/amdsmi_cli/__pycache__" + rm -rf "$RPM_INSTALL_PREFIX0/@SHARE_INSTALL_PREFIX@/amdsmi/__pycache__" # remove build and egg files - rm -rf "@CPACK_PACKAGING_INSTALL_PREFIX@/@SHARE_INSTALL_PREFIX@/amdsmi.egg-info" - rm -rf "@CPACK_PACKAGING_INSTALL_PREFIX@/@SHARE_INSTALL_PREFIX@/build" + rm -rf "$RPM_INSTALL_PREFIX0/@SHARE_INSTALL_PREFIX@/amdsmi.egg-info" + rm -rf "$RPM_INSTALL_PREFIX0/@SHARE_INSTALL_PREFIX@/build" # remove leftover doc files - if test -e "@CPACK_PACKAGING_INSTALL_PREFIX@/@SHARE_INSTALL_PREFIX@/../doc/amd_smi*"; then - rm -rf "@CPACK_PACKAGING_INSTALL_PREFIX@/@SHARE_INSTALL_PREFIX@/../doc/amd_smi*" + if test -e "$RPM_INSTALL_PREFIX0/@SHARE_INSTALL_PREFIX@/../doc/amd_smi*"; then + rm -rf "$RPM_INSTALL_PREFIX0/@SHARE_INSTALL_PREFIX@/../doc/amd_smi*" fi } @@ -22,8 +22,8 @@ rm_logFolder() { rm_rocm_tests_dir(){ - if [ -d "@CPACK_PACKAGING_INSTALL_PREFIX@/share/amd_smi/tests/" ]; then - rm -rf "@CPACK_PACKAGING_INSTALL_PREFIX@/share/amd_smi/tests/" + if [ -d "$RPM_INSTALL_PREFIX0/share/amd_smi/tests/" ]; then + rm -rf "$RPM_INSTALL_PREFIX0/share/amd_smi/tests/" echo "Removed ROCm tests directory." fi } @@ -83,7 +83,7 @@ rm_python_lib() { if [ "$1" -le 1 ]; then # perform the below actions for rpm remove($1=0) or upgrade($1=1) operations # remove old gpuv-smi symlink - rm -f @CPACK_PACKAGING_INSTALL_PREFIX@/bin/gpuv-smi &> /dev/null + rm -f $RPM_INSTALL_PREFIX0/bin/gpuv-smi &> /dev/null rm_python_lib rm_leftovers rm_logFolder