AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix/RO Backend Hang Issue (#53)

Browse Source 
* Update HIP version check for compatibility with versions >= 5.5

* Update memory allocator for context BlockHandle
   - Replaced `HIPAllocator` with `HIPDefaultFinegrainedAllocator` for context `BlockHandle`.

* Update run commands for `rocshmem_g` and `rocshmem_p` functional tests
This commit is contained in:
Avinash Kethineedi
2025-03-24 22:54:07 -05:00
committed by GitHub
parent bcbc42e78f
commit c16b0d6952
3 changed files with 12 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/memory/hip_allocator.hpp
+2 -1
View File
@@ -37,7 +37,8 @@
#include "memory_allocator.hpp"
// `hipDeviceMallocUncached` was introduced at ROCm 5.5
#if HIP_VERSION_MAJOR >= 5 && HIP_VERSION_MINOR >= 5
#if (HIP_VERSION_MAJOR > 5) || \
(HIP_VERSION_MAJOR == 5 && HIP_VERSION_MINOR >= 5)
#define HIP_SUPPORTS_MALLOC_UNCACHED
#endif
namespace rocshmem {
src/reverse_offload/block_handle.hpp
+2 -2
View File
@@ -83,7 +83,7 @@ class DefaultBlockHandleProxy {
ProxyT proxy_{};
};
using DefaultBlockHandleProxyT = DefaultBlockHandleProxy<HIPAllocator>;
using DefaultBlockHandleProxyT = DefaultBlockHandleProxy<HIPDefaultFinegrainedAllocator>;
template <typename ALLOCATOR>
class BlockHandleProxy {
@@ -130,7 +130,7 @@ class BlockHandleProxy {
size_t num_blocks_{};
};
using BlockHandleProxyT = BlockHandleProxy<HIPAllocator>;
using BlockHandleProxyT = BlockHandleProxy<HIPDefaultFinegrainedAllocator>;
} // namespace rocshmem