diff --git a/projects/amdsmi/amdsmi_cli/amdsmi_commands.py b/projects/amdsmi/amdsmi_cli/amdsmi_commands.py index ca01290628..7300e6b69d 100644 --- a/projects/amdsmi/amdsmi_cli/amdsmi_commands.py +++ b/projects/amdsmi/amdsmi_cli/amdsmi_commands.py @@ -592,12 +592,11 @@ class AMDSMICommands(): for fw_index, fw_entry in enumerate(fw_info['fw_list']): # Change fw_name to fw_id fw_entry['fw_id'] = fw_entry.pop('fw_name').name.strip('FW_ID_') - fw_entry['fw_version'] = fw_entry.pop('fw_version') - firmware_identifier = 'FW' + fw_entry['fw_version'] = fw_entry.pop('fw_version') # popping to ensure order # Add custom human readable formatting if self.logger.is_human_readable_format(): - fw_info['fw_list'][fw_index] = {f'{firmware_identifier} {fw_index}': fw_entry} + fw_info['fw_list'][fw_index] = {f'FW {fw_index}': fw_entry} else: fw_info['fw_list'][fw_index] = fw_entry diff --git a/projects/amdsmi/py-interface/README.md b/projects/amdsmi/py-interface/README.md index 25845075c1..55f36ba0eb 100644 --- a/projects/amdsmi/py-interface/README.md +++ b/projects/amdsmi/py-interface/README.md @@ -576,7 +576,7 @@ try: firmware_list = amdsmi_get_fw_info(device)['fw_list'] for firmware_block in firmware_list: print(firmware_block['fw_name']) - print(firmware_block['fw_version']) + print(firmware_block['fw_version']) # String formated hex version ie: 21.00.00.AC except AmdSmiException as e: print(e) ``` diff --git a/projects/amdsmi/py-interface/amdsmi_interface.py b/projects/amdsmi/py-interface/amdsmi_interface.py index 2b832eb7cd..02be4c5086 100644 --- a/projects/amdsmi/py-interface/amdsmi_interface.py +++ b/projects/amdsmi/py-interface/amdsmi_interface.py @@ -1365,11 +1365,14 @@ def amdsmi_get_fw_info( fw_info = amdsmi_wrapper.amdsmi_fw_info_t() _check_res(amdsmi_wrapper.amdsmi_get_fw_info( processor_handle, ctypes.byref(fw_info))) - firmwares = list() + + firmwares = [] for i in range(0, fw_info.num_fw_info): + fw_version = hex(fw_info.fw_info_list[i].fw_version) + fw_version_string = ".".join(re.findall('..?', fw_version[2:])) firmwares.append({ 'fw_name': AmdSmiFwBlock(fw_info.fw_info_list[i].fw_id), - 'fw_version': fw_info.fw_info_list[i].fw_version, + 'fw_version': fw_version_string.upper(), }) return { 'fw_list': firmwares