Adding agent-index (#189)

* Adding agent-index

* review changes

* review comments addressed

* minor fix

* fix CI failure

* review comments

* Fix agent index test and address review comments

* Build Fixes

---------

Co-authored-by: Benjamin Welton <bewelton@amd.com>
This commit is contained in:
Nagaraj, Sriraksha
2025-03-14 02:51:32 -05:00
committato da GitHub
parent 2fe63d873e
commit c30bb7cbda
32 ha cambiato i file con 604 aggiunte e 108 eliminazioni
+26 -28
Vedi File
@@ -476,15 +476,13 @@ write_otf2(
{
for(auto& [agent, evt] : itr)
{
const auto* _agent = _get_agent(agent);
auto _type_name = std::string_view{"UNK"};
if(_agent->type == ROCPROFILER_AGENT_TYPE_CPU)
_type_name = "CPU";
else if(_agent->type == ROCPROFILER_AGENT_TYPE_GPU)
_type_name = "GPU";
evt.name = fmt::format(
"Thread {}, Copy to {} {}", tid, _type_name, _agent->logical_node_type_id);
const auto* _agent = _get_agent(agent);
auto agent_index_info =
tool_metadata.get_agent_index(_agent->id, cfg.agent_index_value);
evt.name = fmt::format("Thread {}, Copy to {} {}",
tid,
agent_index_info.type,
agent_index_info.as_string("-"));
}
}
@@ -501,16 +499,20 @@ write_otf2(
{
_agent = _get_agent(agent);
}
auto _type_name = std::string_view{"UNK"};
if(_agent != nullptr && _agent->type == ROCPROFILER_AGENT_TYPE_CPU)
_type_name = "CPU";
else if(_agent != nullptr && _agent->type == ROCPROFILER_AGENT_TYPE_GPU)
_type_name = "GPU";
evt.name = fmt::format("Thread {}, Memory Operation at {} {}",
tid,
_type_name,
_agent == nullptr ? 0 : _agent->logical_node_type_id);
if(_agent)
{
auto agent_index_info =
tool_metadata.get_agent_index(_agent->id, cfg.agent_index_value);
evt.name = fmt::format("Thread {}, Memory Operation at {} {}",
tid,
agent_index_info.type,
agent_index_info.as_string("-"));
}
else
{
auto _type_name = std::string_view{"UNK"};
evt.name = fmt::format("Thread {}, Memory Operation at {} {}", tid, _type_name, 0);
}
}
}
@@ -532,17 +534,13 @@ write_otf2(
{
for(auto& [queue, evt] : qitr)
{
const auto* _agent = _get_agent(agent);
auto _type_name = std::string_view{"UNK"};
if(_agent->type == ROCPROFILER_AGENT_TYPE_CPU)
_type_name = "CPU";
else if(_agent->type == ROCPROFILER_AGENT_TYPE_GPU)
_type_name = "GPU";
const auto* _agent = _get_agent(agent);
auto agent_index_info =
tool_metadata.get_agent_index(_agent->id, cfg.agent_index_value);
evt.name = fmt::format("Thread {}, Compute on {} {}, Queue {}",
tid,
_type_name,
_agent->logical_node_type_id,
agent_index_info.type,
agent_index_info.as_string("-"),
_queue_ids.at(queue));
}
}