From c3b5d0a77a2add505b2fce718934a7c7d34e02e4 Mon Sep 17 00:00:00 2001
From: Charis Poag <Charis.Poag@amd.com>
Date: Sun, 14 Jan 2024 19:22:31 -0600
Subject: [PATCH] Fix AMD-SMI test segmentation fault TestGpuMetricsRead

Issue: need to return on any failure.
The nullptr check test would segfault without-
all values in struct are not initialized.

Signed-off-by: Charis Poag <Charis.Poag@amd.com>
Change-Id: I4987fb73ba9bcb182de7a439a4286333a41bf7eb
(cherry picked from commit d74be3120e09b5b4c456b311b37aa5c86438115f)
---
 src/amd_smi/amd_smi.cc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/amd_smi/amd_smi.cc b/src/amd_smi/amd_smi.cc
index ae4b5af69b..aff25228b2 100644
--- a/src/amd_smi/amd_smi.cc
+++ b/src/amd_smi/amd_smi.cc
@@ -1084,6 +1084,9 @@ amdsmi_status_t  amdsmi_get_gpu_metrics_info(
     amdsmi_status_t ret =
             rsmi_wrapper(rsmi_dev_gpu_metrics_info_get, processor_handle,
                     reinterpret_cast<rsmi_gpu_metrics_t*>(pgpu_metrics));
+    if (ret != AMDSMI_STATUS_SUCCESS) {
+        return ret;
+    }
     // WARNING: TEMPORARY - awaiting 1.5 update from amdgpu driver/firmware
     // intended to be removed later
     // START: REMOVE WHATS BELOW ME