AI/rocm-systems
2
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SWDEV-502224 - Fix HIP catch2 test failure in CPX NPS4 mode

Browse Source 
Add dynamic arrays of devices to avoid array overflow.
Fixed the following tests:
Unit_hipDeviceGetByPCIBusId_WrongBusID)
Unit_hipSetDevice_ValidVisibleDeviceList
Unit_hipSetDevice_MinRvdMaxHvdDevicesList

Change-Id: I73d022321609d20ef2bd419f2cff287f6002a4d2
This commit is contained in:
Dragoslav Sicarov authored and Maneesh Gupta committed 2025-02-19 11:35:58 -05:00
1 parent 48989fbfc6
commit c4135a6090
2 files changed
+41 -50
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

catch/unit/device/hipDeviceGetByPCIBusId.cc
+6 -6
View File
@@ -133,19 +133,19 @@ TEST_CASE("Unit_hipDeviceGetByPCIBusId_WrongBusID") {
int deviceCount = 0;
HIP_CHECK(hipGetDeviceCount(&deviceCount));
HIP_ASSERT(deviceCount != 0);
constexpr int MaxLen = 20;
constexpr int MaxIter = 256;
constexpr int MaxBusIdLen = 12;
int pciBusId[MaxLen], pciDeviceID[MaxLen],
pciDomainID[MaxLen];
std::vector<int> pciBusId;
std::vector<int> pciDeviceID;
std::vector<int> pciDomainID;
// get bus id of all the devices
for (int i = 0; i < deviceCount; i++) {
hipDeviceProp_t prop;
HIP_CHECK(hipGetDeviceProperties(&prop, i));
pciBusId[i] = prop.pciBusID;
pciDeviceID[i] = prop.pciDeviceID;
pciDomainID[i] = prop.pciDomainID;
pciBusId.push_back(prop.pciBusID);
pciDeviceID.push_back(prop.pciDeviceID);
pciDomainID.push_back(prop.pciDomainID);
printf("device %d: pciDomainID=%x, pciBusID=%x, pciDeviceID=%x \n",
i, prop.pciDomainID, prop.pciBusID, prop.pciDomainID);
}