From c4462940dbc5b1a82dcdd45aeebef96a71d62cea Mon Sep 17 00:00:00 2001
From: foreman <dl.constructicon@amd.com>
Date: Fri, 23 Feb 2018 19:23:42 -0500
Subject: [PATCH] P4 to Git Change 1519084 by gandryey@gera-w8 on 2018/02/23
 19:15:27

	SWDEV-79445 - OCL generic changes and code clean-up
	- Remove debugger checks from the dispatch path. There are no plans to enable debugger in the near future.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.cpp#74 edit


[ROCm/clr commit: b561617774cd924a6a7f6339646af15c68ce1432]
---
 .../rocclr/runtime/device/pal/palvirtual.cpp  | 34 +++----------------
 1 file changed, 5 insertions(+), 29 deletions(-)

diff --git a/projects/clr/rocclr/runtime/device/pal/palvirtual.cpp b/projects/clr/rocclr/runtime/device/pal/palvirtual.cpp
index 479f64096e..f053f0f1e2 100644
--- a/projects/clr/rocclr/runtime/device/pal/palvirtual.cpp
+++ b/projects/clr/rocclr/runtime/device/pal/palvirtual.cpp
@@ -2085,11 +2085,6 @@ bool VirtualGPU::submitKernelInternal(const amd::NDRangeContainer& sizes, const
                                       const_address parameters, bool nativeMem,
                                       amd::Event* enqueueEvent)
 {
-  uint64_t vmParentWrap = 0;
-  uint64_t vmDefQueue = 0;
-  VirtualGPU* gpuDefQueue = nullptr;
-  amd::HwDebugManager* dbgManager = dev().hwDebugMgr();
-
   // If RGP capturing is enabled, then start SQTT trace
   if (rgpCaptureEna()) {
     dev().rgpCaptureMgr()->PreDispatch(this);
@@ -2110,8 +2105,11 @@ bool VirtualGPU::submitKernelInternal(const amd::NDRangeContainer& sizes, const
     return false;
   }
 
+  // Add ISA memory object to the resource tracking list
   AddKernel(kernel);
 
+  uint64_t vmDefQueue = 0;
+  VirtualGPU* gpuDefQueue = nullptr;
   if (hsaKernel.dynamicParallelism()) {
     // Initialize GPU device queue for execution (gpuDefQueue)
     if (!PreDeviceEnqueue(kernel, hsaKernel, &gpuDefQueue, &vmDefQueue)) {
@@ -2119,14 +2117,7 @@ bool VirtualGPU::submitKernelInternal(const amd::NDRangeContainer& sizes, const
     }
   }
 
-  //  setup the storage for the memory pointers of the kernel parameters
-  uint numParams = kernel.signature().numParameters();
-  if (dbgManager) {
-    dbgManager->allocParamMemList(numParams);
-  }
-
   bool needFlush = false;
-
   // Avoid flushing when PerfCounter is enabled, to make sure PerfStart/dispatch/PerfEnd
   // are in the same cmdBuffer
   if (!state_.perfCounterEnabled_) {
@@ -2175,6 +2166,7 @@ bool VirtualGPU::submitKernelInternal(const amd::NDRangeContainer& sizes, const
     amd::NDRangeContainer tmpSizes(sizes.dimensions(), &newOffset[0], &newGlobalSize[0],
                                    &(const_cast<amd::NDRangeContainer&>(sizes).local()[0]));
 
+    uint64_t vmParentWrap = 0;
     // Program the kernel arguments for the GPU execution
     hsa_kernel_dispatch_packet_t* aqlPkt = hsaKernel.loadArguments(
         *this, kernel, tmpSizes, parameters, nativeMem, vmDefQueue, &vmParentWrap);
@@ -2190,15 +2182,6 @@ bool VirtualGPU::submitKernelInternal(const amd::NDRangeContainer& sizes, const
       addVmMemory(scratch->memObj_);
     }
 
-    // HW Debug for the kernel?
-    HwDbgKernelInfo kernelInfo;
-    HwDbgKernelInfo* pKernelInfo = nullptr;
-
-    if (dbgManager) {
-      buildKernelInfo(hsaKernel, aqlPkt, kernelInfo, enqueueEvent);
-      pKernelInfo = &kernelInfo;
-    }
-
     // Set up the dispatch information
     Pal::DispatchAqlParams dispatchParam = {};
     dispatchParam.pAqlPacket = aqlPkt;
@@ -2222,13 +2205,6 @@ bool VirtualGPU::submitKernelInternal(const amd::NDRangeContainer& sizes, const
     }
     eventEnd(MainEngine, gpuEvent);
 
-    if (id != gpuEvent.id) {
-      LogError("something is wrong. ID mismatch!\n");
-    }
-    if (dbgManager && (nullptr != dbgManager->postDispatchCallBackFunc())) {
-      dbgManager->executePostDispatchCallBack();
-    }
-
     // Execute scheduler for device enqueue
     if (hsaKernel.dynamicParallelism()) {
       PostDeviceEnqueue(kernel, hsaKernel, gpuDefQueue, vmDefQueue, vmParentWrap, &gpuEvent);
@@ -2245,7 +2221,7 @@ bool VirtualGPU::submitKernelInternal(const amd::NDRangeContainer& sizes, const
       return false;
     }
   }
-
+  // Perform post dispatch logic for RGP traces
   if (rgpCaptureEna()) {
     dev().rgpCaptureMgr()->PostDispatch(this);
   }