PC Sampling - blit kernels handling (#878)
* correlation id 0 for blit kernels' samples * rocprofiler_pc_sampling_snapshot_v1_t docs update (for future use) * ROCPROFILER_CORRELATION_ID_VALUE_NONE introduced * Simplifying ROCPROFILER_CORRELATION_ID_VALUE_NONE * Apply suggestions from code review Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com> --------- Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com>
This commit is contained in:
zatwierdzone przez
GitHub
rodzic
dc054eea76
commit
c45bf712d1
@@ -519,6 +519,11 @@ typedef struct
|
||||
rocprofiler_user_data_t external;
|
||||
} rocprofiler_correlation_id_t;
|
||||
|
||||
/**
|
||||
* @brief The NULL correlation ID value.
|
||||
*/
|
||||
#define ROCPROFILER_CORRELATION_ID_VALUE_NONE 0ULL
|
||||
|
||||
/**
|
||||
* @struct rocprofiler_buffer_id_t
|
||||
* @brief Buffer ID.
|
||||
|
||||
@@ -197,7 +197,7 @@ rocprofiler_query_pc_sampling_agent_configurations(
|
||||
*/
|
||||
typedef struct
|
||||
{
|
||||
uint8_t valid : 1; /// sample is valid
|
||||
uint8_t valid : 1; /// ::rocprofiler_pc_sampling_snapshot_v1_t field is valid
|
||||
uint8_t type : 4;
|
||||
uint8_t has_stall_reason : 1;
|
||||
uint8_t has_wave_cnt : 1;
|
||||
@@ -219,7 +219,12 @@ typedef struct
|
||||
} rocprofiler_pc_sampling_header_v1_t;
|
||||
|
||||
/**
|
||||
* @brief TODO: provide the description
|
||||
* @brief For future use.
|
||||
*
|
||||
* @todo: Provide the description
|
||||
* @todo: Should we use bitfields because of C ABI portability?
|
||||
* @todo: Should we abstract this to be architecture agnostic?
|
||||
* @todo: Consider having a query to determine organization of this information.
|
||||
*/
|
||||
typedef struct
|
||||
{
|
||||
|
||||
Reference in New Issue
Block a user