From c4d2a2c557bb15eea8fcaf6363c7efa33a912bc2 Mon Sep 17 00:00:00 2001 From: Ioannis Assiouras Date: Tue, 20 Dec 2022 09:48:58 +0000 Subject: [PATCH] SWDEV-374400, SWDEV-374404 - Change error message in hipFuncGetAttribute(s) to match nvidia. Change-Id: I95b69a49ced24115f0aebc288ea067a49b770aca [ROCm/clr commit: 97c5f772c6a04c4df9a7d6deab40260af988f145] --- projects/clr/hipamd/src/hip_module.cpp | 2 +- projects/clr/hipamd/src/hip_platform.cpp | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/projects/clr/hipamd/src/hip_module.cpp b/projects/clr/hipamd/src/hip_module.cpp index a381311b60..e1c801b81f 100644 --- a/projects/clr/hipamd/src/hip_module.cpp +++ b/projects/clr/hipamd/src/hip_module.cpp @@ -114,7 +114,7 @@ hipError_t hipModuleGetGlobal(hipDeviceptr_t* dptr, size_t* bytes, hipModule_t h hipError_t hipFuncGetAttribute(int* value, hipFunction_attribute attrib, hipFunction_t hfunc) { HIP_INIT_API(hipFuncGetAttribute, value, attrib, hfunc); - if ((value == nullptr) || (hfunc == nullptr)) { + if ((value == nullptr)) { HIP_RETURN(hipErrorInvalidValue); } diff --git a/projects/clr/hipamd/src/hip_platform.cpp b/projects/clr/hipamd/src/hip_platform.cpp index 8f532361bc..afcbaab007 100644 --- a/projects/clr/hipamd/src/hip_platform.cpp +++ b/projects/clr/hipamd/src/hip_platform.cpp @@ -860,9 +860,12 @@ hipError_t PlatformState::getStatFunc(hipFunction_t* hfunc, const void* hostFunc hipError_t PlatformState::getStatFuncAttr(hipFuncAttributes* func_attr, const void* hostFunction, int deviceId) { - if (func_attr == nullptr || hostFunction == nullptr) { + if (func_attr == nullptr) { return hipErrorInvalidValue; } + if (hostFunction == nullptr) { + return hipErrorInvalidDeviceFunction; + } return statCO_.getStatFuncAttr(func_attr, hostFunction, deviceId); }