From c505fd6a2b39d62dded568d23a25977c30ae314c Mon Sep 17 00:00:00 2001 From: gobhardw Date: Tue, 24 Oct 2023 12:01:37 +0530 Subject: [PATCH] SWDEV-427842: Fixing ATT csv mode Change-Id: I7b8f37867d7aaf6da1301d91028990c343e555f1 - Updated README for kernel name truncation. - Updated CHANGELOG. - By default enabled truncation for ATT because csv file names should be smaller Change-Id: I7b8f37867d7aaf6da1301d91028990c343e555f1 [ROCm/rocprofiler commit: 296c935874bbc9f8c3fef91a43104b5c9afc93ef] --- projects/rocprofiler/CHANGELOG.md | 1 + projects/rocprofiler/README.md | 9 +++++++++ projects/rocprofiler/bin/rocprofv2 | 1 + 3 files changed, 11 insertions(+) diff --git a/projects/rocprofiler/CHANGELOG.md b/projects/rocprofiler/CHANGELOG.md index 32eeb9b717..1e61a960bd 100644 --- a/projects/rocprofiler/CHANGELOG.md +++ b/projects/rocprofiler/CHANGELOG.md @@ -301,3 +301,4 @@ Example for file plugin output: - Updated supported GPU architectures in README with profiler versions - Automatic ISA dumping for ATT. See README. - CSV mode for ATT. See README. +- Added option to control kernel name truncation. diff --git a/projects/rocprofiler/README.md b/projects/rocprofiler/README.md index eac09a9d3e..cb394b991e 100644 --- a/projects/rocprofiler/README.md +++ b/projects/rocprofiler/README.md @@ -533,6 +533,7 @@ A device profiling session allows the user to profile the GPU device for counter - PERFCOUNTERS_COL_PERIOD=0x3 // Multiplier period for counter collection [0~31]. 0=fastest (usually once every 16 cycles). GFX9 only. Counters will be shown in a graph over time in the browser UI. - PERFCOUNTER=counter_name // Add a SQ counter to be collected with ATT; period defined by PERFCOUNTERS_COL_PERIOD. GFX9 only. - BUFFER_SIZE=[size] // Sets size of the ATT buffer collection, per dispatch, in megabytes (shared among all shader engines). + - By default, kernel names are truncated for ATT.To disable, please see the kernel name truncation section below. ## Tests @@ -593,6 +594,14 @@ To enable error messages logging to '/tmp/rocprofiler_log.txt': export ROCPROFILER_LOG=1 ``` +## Kernel Name Truncation + +By default kernel names are not truncated. To enable truncation for readability: + +``` +export ROCPROFILER_TRUNCATE_KERNEL_PATH=1 +``` + ## Documentation We make use of doxygen to automatically generate API documentation. Generated document can be found in the following path: diff --git a/projects/rocprofiler/bin/rocprofv2 b/projects/rocprofiler/bin/rocprofv2 index ccc5e62ef0..e74ab6f4e9 100755 --- a/projects/rocprofiler/bin/rocprofv2 +++ b/projects/rocprofiler/bin/rocprofv2 @@ -201,6 +201,7 @@ while [ 1 ]; do exit 1 fi if [ "$2" = "att" ]; then + export ROCPROFILER_TRUNCATE_KERNEL_PATH=1 if [ $RUN_FROM_BUILD == 1 ]; then ATT_PATH=$ROCM_DIR/plugin/att/att/att.py else