From c5ab37211bbf98817847498cd0f5d770f02e5347 Mon Sep 17 00:00:00 2001 From: Wenkai Du <43822138+wenkaidu@users.noreply.github.com> Date: Wed, 21 Feb 2024 17:15:11 -0800 Subject: [PATCH] Update RCCL/MSCCL work FIFO depth to 256K (#1091) --- src/init.cc | 2 +- src/misc/msccl/msccl_setup.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/init.cc b/src/init.cc index be42cc1352..41aae75558 100644 --- a/src/init.cc +++ b/src/init.cc @@ -443,7 +443,7 @@ NCCL_PARAM(AggChannelSize, "AGG_CHANNEL_SIZE", -2); NCCL_PARAM(DisableGraphHelper, "GRAPH_HELPER_DISABLE", 0); // GDRCOPY support: FIFO_ENABLE when enabled locates a workFifo in CUDA memory NCCL_PARAM(GdrCopyFifoEnable, "GDRCOPY_FIFO_ENABLE", 1); -NCCL_PARAM(WorkFifoDepth, "WORK_FIFO_DEPTH", 64<<10); +NCCL_PARAM(WorkFifoDepth, "WORK_FIFO_DEPTH", 256<<10); enum ncclLaunchMode ncclParamLaunchMode; diff --git a/src/misc/msccl/msccl_setup.cc b/src/misc/msccl/msccl_setup.cc index 21be019361..b418dabcd5 100644 --- a/src/misc/msccl/msccl_setup.cc +++ b/src/misc/msccl/msccl_setup.cc @@ -20,7 +20,7 @@ RCCL_PARAM(MscclEnableDoneEvent, "MSCCL_ENABLE_DONE_EVENT", 1); #endif -RCCL_PARAM(MscclWorkFifoDepth, "MSCCL_WORK_FIFO_DEPTH", 64<<10); +RCCL_PARAM(MscclWorkFifoDepth, "MSCCL_WORK_FIFO_DEPTH", 256<<10); static inline size_t computeSizeNeeded(size_t nBytes, int nScratchChunks, int nChunksPerLoop) { return (nBytes * (size_t)nScratchChunks) / (size_t)nChunksPerLoop;