From c8caa804056b10b7fc259c6571f8d93e33b5a577 Mon Sep 17 00:00:00 2001
From: "Bill(Shuzhou) Liu" <shuzhou.liu@amd.com>
Date: Mon, 31 Oct 2022 09:46:47 -0500
Subject: [PATCH] Fix the unit tests

Fix a few broken unit tests to handle NOT_YET_IMPLEMENTED errors.

Change-Id: If3afac0dc32f2e3e82d83bffa5906b630bb1894a
---
 tests/amd_smi_test/functional/frequencies_read.cc       | 6 ++++++
 tests/amd_smi_test/functional/frequencies_read_write.cc | 3 ++-
 tests/amd_smi_test/functional/pci_read_write.cc         | 3 +++
 tests/amd_smi_test/functional/power_read_write.cc       | 5 +++++
 tests/amd_smi_test/functional/volt_freq_curv_read.cc    | 2 +-
 5 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/tests/amd_smi_test/functional/frequencies_read.cc b/tests/amd_smi_test/functional/frequencies_read.cc
index 6afd01df95..c1eeb0b786 100755
--- a/tests/amd_smi_test/functional/frequencies_read.cc
+++ b/tests/amd_smi_test/functional/frequencies_read.cc
@@ -123,6 +123,9 @@ void TestFrequenciesRead::Run(void) {
           // Verify api support checking functionality is working
           err = amdsmi_dev_gpu_clk_freq_get(device_handles_[i], t, nullptr);
           ASSERT_EQ(err, AMDSMI_STATUS_INVAL);
+        } else if (err == AMDSMI_STATUS_NOT_YET_IMPLEMENTED) {
+          std::cout << "\t**Get " << name <<
+                               ": Not implemented on this machine" << std::endl;
         } else {
             CHK_ERR_ASRT(err)
             IF_VERB(STANDARD) {
@@ -151,6 +154,9 @@ void TestFrequenciesRead::Run(void) {
         // Verify api support checking functionality is working
         err = amdsmi_dev_pci_bandwidth_get(device_handles_[i], nullptr);
         ASSERT_EQ(err, AMDSMI_STATUS_NOT_SUPPORTED);
+      } else if (err == AMDSMI_STATUS_NOT_YET_IMPLEMENTED) {
+          std::cout << "\t**Get PCIE Bandwidth "
+                    << ": Not implemented on this machine" << std::endl;
       } else {
           CHK_ERR_ASRT(err)
           IF_VERB(STANDARD) {
diff --git a/tests/amd_smi_test/functional/frequencies_read_write.cc b/tests/amd_smi_test/functional/frequencies_read_write.cc
index ab4ee8f754..360d41f221 100755
--- a/tests/amd_smi_test/functional/frequencies_read_write.cc
+++ b/tests/amd_smi_test/functional/frequencies_read_write.cc
@@ -116,7 +116,8 @@ void TestFrequenciesReadWrite::Run(void) {
         ret = amdsmi_dev_gpu_clk_freq_get(device_handles_[dv_ind], amdsmi_clk, &f);
         std::cout << ret << std::endl;
 
-        if (ret == AMDSMI_STATUS_NOT_SUPPORTED) {
+        if (ret == AMDSMI_STATUS_NOT_SUPPORTED ||
+            ret == AMDSMI_STATUS_NOT_YET_IMPLEMENTED) {
           std::cout << "\t**Set " << FreqEnumToStr(amdsmi_clk) <<
                                ": Not supported on this machine" << std::endl;
           return false;
diff --git a/tests/amd_smi_test/functional/pci_read_write.cc b/tests/amd_smi_test/functional/pci_read_write.cc
index e663a003fe..7a5844145b 100755
--- a/tests/amd_smi_test/functional/pci_read_write.cc
+++ b/tests/amd_smi_test/functional/pci_read_write.cc
@@ -151,6 +151,9 @@ void TestPciReadWrite::Run(void) {
       ret = amdsmi_dev_pci_bandwidth_get(device_handles_[dv_ind], nullptr);
       ASSERT_EQ(ret, AMDSMI_STATUS_NOT_SUPPORTED);
 
+      return;
+    } else if (ret == AMDSMI_STATUS_NOT_YET_IMPLEMENTED) {
+      std::cout << "TEST FAILURE: Current PCIe bandwidth is not implemented.\n";
       return;
     }
     CHK_ERR_ASRT(ret)
diff --git a/tests/amd_smi_test/functional/power_read_write.cc b/tests/amd_smi_test/functional/power_read_write.cc
index 01408d0825..c675d49b43 100755
--- a/tests/amd_smi_test/functional/power_read_write.cc
+++ b/tests/amd_smi_test/functional/power_read_write.cc
@@ -123,6 +123,11 @@ void TestPowerReadWrite::Run(void) {
     PrintDeviceHeader(device_handles_[dv_ind]);
 
     ret = amdsmi_dev_power_profile_presets_get(device_handles_[dv_ind], 0, &status);
+    if (ret == AMDSMI_STATUS_NOT_SUPPORTED) {
+      std::cout << "The power profile presets settings is not supported. "
+                << std::endl;
+      continue;
+    }
     CHK_ERR_ASRT(ret)
 
     // Verify api support checking functionality is working
diff --git a/tests/amd_smi_test/functional/volt_freq_curv_read.cc b/tests/amd_smi_test/functional/volt_freq_curv_read.cc
index 7c59cb972a..2fc7479f4e 100755
--- a/tests/amd_smi_test/functional/volt_freq_curv_read.cc
+++ b/tests/amd_smi_test/functional/volt_freq_curv_read.cc
@@ -171,7 +171,7 @@ void TestVoltCurvRead::Run(void) {
       CHK_ERR_ASRT(err)
       // Verify api support checking functionality is working
       err = amdsmi_dev_od_volt_info_get(device_handles_[i], nullptr);
-      ASSERT_EQ(err, AMDSMI_STATUS_NOT_SUPPORTED);
+      ASSERT_EQ(err, AMDSMI_STATUS_INVAL);
     }
 
     if (err == AMDSMI_STATUS_SUCCESS) {