AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

librocdxg: Remove static DXCore library dependency

Browse Source 
Remove static linking to libdxcore library from CMakeLists.txt.
This prepares for dynamic loading implementation and eliminates
hard dependency on DXCore being present at build time.

The DXCore functionality will be loaded dynamically at runtime
in subsequent patches, making the library more flexible for
different deployment scenarios.

Signed-off-by: Chengjun Yao <Chengjun.Yao@amd.com>
Signed-off-by: Yang Su <Yang.Su2@amd.com>
Signed-off-by: Flora Cui <flora.cui@amd.com>
Reviewed-by: Shi.Leslie <Yuliang.Shi@amd.com>
This commit is contained in:
Chengjun Yao
2024-01-04 17:47:33 +08:00
committed by Frank Min
parent 3149006d29
commit c8fbb93f03
3 changed files with 306 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
openclose.cpp
+7 -5
View File
@@ -556,6 +556,11 @@ HSAKMT_STATUS HSAKMTAPI hsaKmtOpenKFD(void) {
dxg_runtime->dxg_fd = fd;
}
if (!wsl::thunk::dxcore::DxcoreLoader::Instance().Initialize()) {
pr_err("Failed to load libdxcore.so\n");
result = HSAKMT_STATUS_ERROR;
goto dxcore_loader_failed;
}
hsakmt_hsa_loader_init();
init_page_size();
@@ -563,10 +568,6 @@ HSAKMT_STATUS HSAKMTAPI hsaKmtOpenKFD(void) {
char *useSvmStr = getenv("HSA_USE_SVM");
dxg_runtime->is_svm_api_supported = !(useSvmStr && !strcmp(useSvmStr, "0")) && false;
// result = topology_sysfs_get_system_props(&sys_props);
if (result != HSAKMT_STATUS_SUCCESS)
goto topology_sysfs_failed;
dxg_runtime->dxg_open_count = 1;
if (!atfork_installed) {
@@ -587,7 +588,7 @@ HSAKMT_STATUS HSAKMTAPI hsaKmtOpenKFD(void) {
reset_suballocator();
pthread_mutex_unlock(&dxg_runtime->hsakmt_mutex);
return result;
topology_sysfs_failed:
dxcore_loader_failed:
close(fd);
open_failed:
pthread_mutex_unlock(&dxg_runtime->hsakmt_mutex);
@@ -604,6 +605,7 @@ HSAKMT_STATUS HSAKMTAPI hsaKmtCloseKFD(void) {
if (--dxg_runtime->dxg_open_count == 0) {
close(dxg_runtime->dxg_fd);
dxg_runtime->dxg_fd = -1;
wsl::thunk::dxcore::DxcoreLoader::Instance().Shutdown();
}
result = HSAKMT_STATUS_SUCCESS;