AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixing Usage of session after free

Browse Source 
If hsa_shut_down() is not called from the application then we may still have async calls back
to the rocprofiler to use session parameters, thats why we need to leak the session up till
this is fixed in the ROCR-Runtime

Change-Id: Ia8fcdaa859815d88a272296770d702968132e3e6
This commit is contained in:
Ammar ELWazir
2023-10-20 00:58:32 +00:00
committed by Ammar Elwazir
parent cb190b72f1
commit c9b5d73ca8
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/tools/tool.cpp
+7 -3
View File
@@ -428,9 +428,13 @@ void finish() {
rocprofiler::TraceBufferBase::FlushAll();
CHECK_ROCPROFILER(rocprofiler_terminate_session(session_id));
}
if (session_id.handle > 0) {
CHECK_ROCPROFILER(rocprofiler_destroy_session(session_id));
}
// If hsa_shut_down() is not called from the application then we may still have async calls back
// to the rocprofiler to use session parameters, thats why we need to leak the session up till
// this is fixed in the ROCR-Runtime
// if (session_id.handle > 0) {
// CHECK_ROCPROFILER(rocprofiler_destroy_session(session_id));
// }
}
static bool env_var_search(std::string& s) {