From c9dd49c48a1846d999e2f4ab97ba2d8c923a080f Mon Sep 17 00:00:00 2001 From: JC Date: Fri, 14 Nov 2025 14:04:54 -0800 Subject: [PATCH] Fix SignatureDoesNotMatch by aws credential option (#1867) Replicating https://github.com/ROCm/TheRock/pull/2147#discussion_r2528008441 ## Motivation Fixes https://github.com/ROCm/TheRock/issues/875 which is the issue where Windows builds would fail randomly when uploading to s3 with the `SignatureDoesNotMatch` error as a result of special characters existing in the AWS Access Keys generated by the `configure-aws-credentials` action that is passed through Windows environment variables to `aws-cli`. More details below. ## Technical Details https://github.com/ROCm/TheRock/issues/875#issuecomment-3530851762 In summary, in Windows workflows, the `special-characters-workaround` option is set to true for the `configure-aws-credentials` action which will regenerate access keys until there are no special characters that may not be passable through windows environment variables correctly. ## Test Plan Observe CI. ## Test Result TBD. ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. --- .github/workflows/therock-ci-windows.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/therock-ci-windows.yml b/.github/workflows/therock-ci-windows.yml index 072bfa5bd6..810d02ea0b 100644 --- a/.github/workflows/therock-ci-windows.yml +++ b/.github/workflows/therock-ci-windows.yml @@ -139,6 +139,7 @@ jobs: with: aws-region: us-east-2 role-to-assume: arn:aws:iam::692859939525:role/therock-artifacts-external + special-characters-workaround: true - name: Post Build Upload if: always()