AI/rocm-systems
2
0
Fork 0
程式碼 問題 合併請求 Actions 套件 專案 版本發布 Wiki 動態

Merge pull request #183 from wenkaidu/dup_rings

瀏覽代碼 
Remove condition for ring duplication

[ROCm/rccl commit: 0976e47b06]
此提交包含在：
Wenkai Du
2020-03-02 17:12:42 -08:00
提交者 GitHub
父節點 dba615366b 85fd51a06f
當前提交 cb19bce4e0
共有 1 個檔案被更改，包括 5 行新增 和 7 行删除
下載 Patch 檔 下載差異檔 展開所有檔案 折疊所有檔案
projects/rccl/src/graph/connect.cc
+5 -7
查看文件
@@ -235,14 +235,12 @@ ncclResult_t ncclTopoPostset(struct ncclComm* comm, int* firstRanks, struct nccl
NCCLCHECK(connectRings(comm, ringRecv, ringSend, ringPrev, ringNext, firstRanks)); NCCLCHECK(connectRings(comm, ringRecv, ringSend, ringPrev, ringNext, firstRanks));
NCCLCHECK(connectTrees(comm, treeUpRecv, treeUpSend, treeDnRecv, treeDnSend, firstRanks)); NCCLCHECK(connectTrees(comm, treeUpRecv, treeUpSend, treeDnRecv, treeDnSend, firstRanks));
if (nChannels == 1) { // Duplicate ringPrev/ringNext for ncclBuildRing
// Duplicate ringPrev/ringNext for ncclBuildRing memcpy(ringPrev+nChannels*nranks, ringPrev, nChannels*nranks*sizeof(int));
memcpy(ringPrev+nChannels*nranks, ringPrev, nChannels*nranks*sizeof(int)); memcpy(ringNext+nChannels*nranks, ringNext, nChannels*nranks*sizeof(int));
memcpy(ringNext+nChannels*nranks, ringNext, nChannels*nranks*sizeof(int));
// Duplication should be complete now // Duplication should be complete now
nChannels = comm->nChannels = std::min(MAXCHANNELS,nChannels*2); nChannels = comm->nChannels = std::min(MAXCHANNELS,nChannels*2);
}
// Honor NCCL_MIN_NRINGS/NCCL_MAX_NRINGS. // Honor NCCL_MIN_NRINGS/NCCL_MAX_NRINGS.
// We permit combining max, then min, to only use the first channels, then duplicate them. // We permit combining max, then min, to only use the first channels, then duplicate them.