Memory Allocation Counter Track Shows Total Allocation (#71)

* Counter track for memory allocation is now a running sum showing total allocation

* Address review comments

* Update source/lib/output/generatePerfetto.cpp

Co-authored-by: Meserve, Mark <Mark.Meserve@amd.com>

* Updated to reflect review comments

* Fix compilation errors on CI

* remove braces on scalar

* Fix struct compilation issues

* Removed name_to_id for sanitizer

---------

Co-authored-by: Meserve, Mark <Mark.Meserve@amd.com>
This commit is contained in:
Trowbridge, Ian
2025-02-12 12:59:53 -06:00
committed by GitHub
parent 5d0b220c37
commit cc0c401615
10 changed files with 166 additions and 65 deletions
@@ -336,7 +336,7 @@ struct memory_allocation_data
rocprofiler_thread_id_t tid = common::get_tid();
rocprofiler_agent_id_t agent = null_rocp_agent_id;
uint64_t size_allocated = 0;
rocprofiler_address_t address = {.value = 0};
rocprofiler_address_t address = {.handle = 0};
uint64_t start_ts = 0;
context::correlation_id* correlation_id = nullptr;
tracing::tracing_data tracing_data = {};
@@ -428,7 +428,7 @@ handle_starting_addr(void** starting_addr_pointer)
rocprofiler_address_t
handle_starting_addr(hsa_amd_vmem_alloc_handle_t* vmem_alloc_handle)
{
return rocprofiler_address_t{.value = (vmem_alloc_handle) ? vmem_alloc_handle->handle : 0};
return rocprofiler_address_t{.handle = (vmem_alloc_handle) ? vmem_alloc_handle->handle : 0};
}
// Handling starting address for free memory operations
@@ -442,7 +442,7 @@ handle_starting_addr(void* starting_addr_pointer)
rocprofiler_address_t
handle_starting_addr(hsa_amd_vmem_alloc_handle_t vmem_alloc_handle)
{
return rocprofiler_address_t{.value = vmem_alloc_handle.handle};
return rocprofiler_address_t{.handle = vmem_alloc_handle.handle};
}
// Wrapper implementation that stores memory allocation information