From ccb09057d8b55a569f7e7ca120d3c04c7409d7a0 Mon Sep 17 00:00:00 2001 From: Sameer Sahasrabuddhe Date: Thu, 24 Oct 2024 12:16:46 +0530 Subject: [PATCH] SWDEV-490198: _sync() will be enabled by default in 6.4 Change-Id: Id029424a9c0f6b144a7aa0e96fe8acc4a138ec51 [ROCm/clr commit: 556390f9c74ff74765f48d8e782cba147d3d7498] --- projects/clr/CHANGELOG.md | 5 +++++ .../hipamd/include/hip/amd_detail/amd_warp_sync_functions.h | 6 ++---- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/projects/clr/CHANGELOG.md b/projects/clr/CHANGELOG.md index 4b0df4d9ef..f5929572e8 100644 --- a/projects/clr/CHANGELOG.md +++ b/projects/clr/CHANGELOG.md @@ -28,6 +28,11 @@ Full documentation for HIP is available at [rocm.docs.amd.com](https://rocm.docs ### Resolved issues +- The `_sync()` version of crosslane builtins such as `shfl_sync()`, + `__all_sync()` and `__any_sync()`, continue to be hidden behind the + preprocessor macro `HIP_ENABLE_WARP_SYNC_BUILTINS`, and will be enabled + unconditionally in the next ROCm release. + ## HIP 6.2.41134 for ROCm 6.2.1 ### Resolved issues diff --git a/projects/clr/hipamd/include/hip/amd_detail/amd_warp_sync_functions.h b/projects/clr/hipamd/include/hip/amd_detail/amd_warp_sync_functions.h index 8ef0b2e1d7..a84dada0ad 100644 --- a/projects/clr/hipamd/include/hip/amd_detail/amd_warp_sync_functions.h +++ b/projects/clr/hipamd/include/hip/amd_detail/amd_warp_sync_functions.h @@ -25,10 +25,8 @@ THE SOFTWARE. // Warp sync builtins (with explicit mask argument) introduced in ROCm 6.2 as a // preview to allow end-users to adapt to the new interface involving 64-bit // masks. These are disabled by default, and can be enabled by setting the macro -// below. The builtins will be enabled unconditionally in ROCm 6.3. -// -// This arrangement also applies to the __activemask() builtin defined in -// amd_warp_functions.h. +// "HIP_ENABLE_WARP_SYNC_BUILTINS". This arrangement also applies to the +// __activemask() builtin defined in amd_warp_functions.h. #ifdef HIP_ENABLE_WARP_SYNC_BUILTINS #if !defined(__HIPCC_RTC__)