rocprofiler library unit tests (#81)

* Update CI and linting workflows - delete linting workflow - compile default CI job with clang-tidy - split out code coverage matrix entry to separate job - code coverage job runs code coverage 3x - once for total code coverage - once for unittests code coverage - once for samples code coverage * Update PTL submodule - improves handling of when thread pool is destroyed in atexit handler * Update lib/rocprofiler/buffer - buffer::instance::get_internal_buffer() - allocate_buffer invokes internal_threading::initialize() on first entry - update flush routine - if wait is false, does not wait for task group to finish syncing - checks for callback pointer * Update lib/rocprofiler/internal_threading - modifications to handle destruction of statics before atexit handler is invoked * Update lib/rocprofiler/registration.cpp - reorder atexit call in initialize() - protect finalize from executing more than once * Add unittests for rocprofiler buffer * Update CI workflow - disable fail-fast for sanitizers - move AddressSanitizer job to top of the list * Update lib/rocprofiler/tests/buffer/CMakeLists.txt - do not set memcheck LD_PRELOAD for rocprofiler-lib-buffer-tests * Update lib/rocprofiler/registration.{hpp,cpp} - only invoke client finalizers if initialized - remove invoke_client_initializer - move invoke_client functions to anonymous namespace (no declaration in header) - set fini status in finalize * Update scripts/thread-sanitizer-suppr.txt - suppress false positive for double mutex lock in external/ptl/source/PTL/TaskGroup.hh * Restructure lib/rocprofiler/tests * Update lib/common - add utility.cpp - move read_command_line to utility.{hpp,cpp} - was formerly in config.cpp * Update lib/rocprofiler - checks for init status return configuration locked if status is not greater than -1 - in other words, this prevents calling these functions directly (which was possible when check was for greater than 0 * Update lib/rocprofiler/context/context.{hpp,cpp} - provide deactivate_client_contexts and deregister_client_contexts - these functions are used when the tool fails to configure * Update lib/rocprofiler/registration.{hpp,cpp} - internal "public" get_client_offet() - client ids are offset by a random value to avoid default values behaving correctly * Update lib/rocprofiler/tests - fix rocprofiler_lib.registration_lambda_no_result * Update lib/rocprofiler/tests - fix rocprofiler_lib.registration_lambda_with_result * Update lib/rocprofiler/tests - remove deep bind from rocprofiler_lib.registration_lambda_with_result * Update lib/rocprofiler/tests - use RTLD_NOW when dlopen'ing in rocprofiler_lib.registration_lambda_with_result * Update rocprofiler registration tests - split registration tests into separate exe that links to shared library * Formatting * Update CI workflow - always checkout submodules via actions/checkout * Update lib/rocprofiler/buffer.{hpp,cpp} - fix issue with buffer flushing not working when only called once * Update rocprofiler lib registration test - test for buffered callback * Update include/rocprofiler/rocprofiler.h - include internal_threading.h header * Update rocprofiler lib registration test - add in internal threading for buffered test [ROCm/rocprofiler-sdk commit: a646c1546c]
2023-09-26 19:21:31 -05:00
@@ -3,7 +3,7 @@
 #
 rocprofiler_activate_clang_tidy()

-set(common_sources config.cpp environment.cpp demangle.cpp)
+set(common_sources config.cpp environment.cpp demangle.cpp utility.cpp)
 set(common_headers config.hpp defines.hpp environment.hpp demangle.hpp mpl.hpp
                   utility.hpp xml.hpp)

@@ -22,6 +22,7 @@
 #include "lib/common/config.hpp"
 #include "lib/common/demangle.hpp"
 #include "lib/common/environment.hpp"
+#include "lib/common/utility.hpp"

 #include <fmt/core.h>

@@ -44,39 +45,6 @@ namespace
 {
 std::time_t* launch_time = new std::time_t{std::time(nullptr)};

-std::vector<std::string>
-read_command_line(pid_t _pid)
-{
-    auto _cmdline = std::vector<std::string>{};
-    auto fcmdline = std::stringstream{};
-    fcmdline << "/proc/" << _pid << "/cmdline";
-    auto ifs = std::ifstream{fcmdline.str().c_str()};
-    if(ifs)
-    {
-        char        cstr;
-        std::string sarg;
-        while(!ifs.eof())
-        {
-            ifs >> cstr;
-            if(!ifs.eof())
-            {
-                if(cstr != '\0')
-                {
-                    sarg += cstr;
-                }
-                else
-                {
-                    _cmdline.push_back(sarg);
-                    sarg = "";
-                }
-            }
-        }
-        ifs.close();
-    }
-
-    return _cmdline;
-}
-
 std::string
 get_local_datetime(const char* dt_format, std::time_t* dt_curr)
 {
@@ -42,6 +42,7 @@ enum class config_context

 int
 get_mpi_size();
+
 int
 get_mpi_rank();

@@ -86,10 +87,13 @@ struct output_key

 std::vector<output_key>
 output_keys(std::string _tag = {});
+
 std::string
 compose_filename(const config&);
+
 std::string
 format(std::string _fpath, const std::string& _tag = {});
+
 std::string
 format_name(std::string_view _name, const config& = get_config<>());

@@ -0,0 +1,67 @@
+// Copyright (c) 2023 Advanced Micro Devices, Inc.
+//
+// Permission is hereby granted, free of charge, to any person obtaining a copy
+// of this software and associated documentation files (the "Software"), to deal
+// in the Software without restriction, including without limitation the rights
+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+// copies of the Software, and to permit persons to whom the Software is
+// furnished to do so, subject to the following conditions:
+//
+// The above copyright notice and this permission notice shall be included in
+// all copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+// THE SOFTWARE.
+//
+
+#include "lib/common/utility.hpp"
+
+#include <unistd.h>
+#include <fstream>
+#include <sstream>
+#include <string>
+#include <vector>
+
+namespace rocprofiler
+{
+namespace common
+{
+std::vector<std::string>
+read_command_line(pid_t _pid)
+{
+    auto _cmdline = std::vector<std::string>{};
+    auto fcmdline = std::stringstream{};
+    fcmdline << "/proc/" << _pid << "/cmdline";
+    auto ifs = std::ifstream{fcmdline.str().c_str()};
+    if(ifs)
+    {
+        char        cstr;
+        std::string sarg;
+        while(!ifs.eof())
+        {
+            ifs >> cstr;
+            if(!ifs.eof())
+            {
+                if(cstr != '\0')
+                {
+                    sarg += cstr;
+                }
+                else
+                {
+                    _cmdline.push_back(sarg);
+                    sarg = "";
+                }
+            }
+        }
+        ifs.close();
+    }
+
+    return _cmdline;
+}
+}  // namespace common
+}  // namespace rocprofiler
@@ -26,6 +26,8 @@
 #include <unistd.h>
 #include <chrono>
 #include <cstdint>
+#include <string>
+#include <vector>

 namespace rocprofiler
 {
@@ -46,6 +48,9 @@ timestamp_ns()
    return std::chrono::steady_clock::now().time_since_epoch().count();
 }

+std::vector<std::string>
+read_command_line(pid_t _pid);
+
 template <class Container, typename Key = typename Container::key_type>
 const auto*
 get_val(const Container& map, const Key& key)