From cfdd30183d6cf104bfbb1f1bcdd2c9e818e4ae3e Mon Sep 17 00:00:00 2001 From: Siu Chi Chan Date: Fri, 20 Jan 2023 20:22:13 +0000 Subject: [PATCH] Link tests to required libraries (#124) A lot of the unit tests make use of the C++ thread library but the cmakefile doesn't explicitly link them to the pthread library but instead rely on hipcc to implicitly link in the pthread library. Some tests that rely on librt have a similar issue. The tests break when we are cleaning up hipcc by removing the implcit linking to those libraries. [ROCm/hip-tests commit: 500dc6f69a96cc140ad6fc5b683a80573fa57359] --- .../hip-tests/catch/external/Catch2/cmake/Catch2/Catch.cmake | 2 ++ 1 file changed, 2 insertions(+) diff --git a/projects/hip-tests/catch/external/Catch2/cmake/Catch2/Catch.cmake b/projects/hip-tests/catch/external/Catch2/cmake/Catch2/Catch.cmake index 6960d0ee3a..0a76641fe5 100644 --- a/projects/hip-tests/catch/external/Catch2/cmake/Catch2/Catch.cmake +++ b/projects/hip-tests/catch/external/Catch2/cmake/Catch2/Catch.cmake @@ -374,6 +374,8 @@ function(hip_add_exe_to_target) if(UNIX) set(_LINKER_LIBS ${_LINKER_LIBS} stdc++fs) set(_LINKER_LIBS ${_LINKER_LIBS} -ldl) + set(_LINKER_LIBS ${_LINKER_LIBS} pthread) + set(_LINKER_LIBS ${_LINKER_LIBS} rt) else() # res files are built resource files using rc files. # use llvm-rc exe to build the res files