From d00346db7be4e81e4019e2d3719385ae099e1edb Mon Sep 17 00:00:00 2001 From: Marko Arandjelovic Date: Mon, 1 Apr 2024 13:01:25 +0200 Subject: [PATCH] SWDEV-452296 - Unit_hipExtModuleLaunchKernel_Positive_Basic removed - No guarantees it will always succeed, could be a little early or late due to various reasons. Change-Id: Id4c45555f9f5e05df8fdf0ad39da4c33ac16fcb9 [ROCm/hip-tests commit: ca5e061bf6b30ce71cf077752ae855a2288f1b74] --- .../catch/hipTestMain/config/config_amd_linux | 2 -- .../hipTestMain/config/config_amd_windows | 1 - .../unit/module/hipExtModuleLaunchKernel.cc | 24 +------------------ 3 files changed, 1 insertion(+), 26 deletions(-) diff --git a/projects/hip-tests/catch/hipTestMain/config/config_amd_linux b/projects/hip-tests/catch/hipTestMain/config/config_amd_linux index 987881ca85..afa82ad0ef 100644 --- a/projects/hip-tests/catch/hipTestMain/config/config_amd_linux +++ b/projects/hip-tests/catch/hipTestMain/config/config_amd_linux @@ -1443,8 +1443,6 @@ "Unit_hipModuleLaunchCooperativeKernelMultiDevice_Positive_Basic", "Unit_hipModuleLaunchCooperativeKernelMultiDevice_Negative_Parameters", "Unit_hipModuleLaunchCooperativeKernelMultiDevice_Negative_MultiKernelSameDevice", - "=== SWDEV-445928: This test failed in PSDB stress test on 09/02/2024 ===", - "Unit_hipExtModuleLaunchKernel_Positive_Basic", #endif #if defined VEGA20 "=== SWDEV-419112 Below tests fail in stress test on 29/08/23 ===", diff --git a/projects/hip-tests/catch/hipTestMain/config/config_amd_windows b/projects/hip-tests/catch/hipTestMain/config/config_amd_windows index b944bec18f..6caf3baf4d 100644 --- a/projects/hip-tests/catch/hipTestMain/config/config_amd_windows +++ b/projects/hip-tests/catch/hipTestMain/config/config_amd_windows @@ -644,7 +644,6 @@ "Unit_hipDrvGetErrorString_Positive_Basic", "Unit_hipModuleLaunchKernel_Negative_Parameters", "Unit_hipModuleGetTexRef_Positive_Basic", - "Unit_hipExtModuleLaunchKernel_Positive_Basic", "Unit_hipExtModuleLaunchKernel_Negative_Parameters", "Unit_hipLaunchKernel_Negative_Parameters", "Unit_Kernel_Launch_bounds_Negative_OutOfBounds", diff --git a/projects/hip-tests/catch/unit/module/hipExtModuleLaunchKernel.cc b/projects/hip-tests/catch/unit/module/hipExtModuleLaunchKernel.cc index e3f6acf682..3896ff8388 100644 --- a/projects/hip-tests/catch/unit/module/hipExtModuleLaunchKernel.cc +++ b/projects/hip-tests/catch/unit/module/hipExtModuleLaunchKernel.cc @@ -44,7 +44,7 @@ THE SOFTWARE. */ #include - + #include #include #include "hip/hip_ext.h" @@ -236,28 +236,6 @@ TEST_CASE("Unit_hipExtModuleLaunchKernel_UniformWorkGroup") { HIP_CHECK(hipModuleUnload(Module)); } -TEST_CASE("Unit_hipExtModuleLaunchKernel_Positive_Basic") { - ModuleLaunchKernelPositiveBasic(); - - SECTION("Timed kernel launch with events") { - hipEvent_t start_event = nullptr, stop_event = nullptr; - HIP_CHECK(hipEventCreate(&start_event)); - HIP_CHECK(hipEventCreate(&stop_event)); - const auto kernel = GetKernel(mg.module(), "Delay"); - int clock_rate = 0; - HIP_CHECK(hipDeviceGetAttribute(&clock_rate, hipDeviceAttributeClockRate, 0)); - uint32_t interval = 100; - uint32_t ticks_per_second = clock_rate; - void* kernel_params[2] = {&interval, &ticks_per_second}; - HIP_CHECK(hipExtModuleLaunchKernel(kernel, 1, 1, 1, 1, 1, 1, 0, nullptr, kernel_params, nullptr, - start_event, stop_event)); - HIP_CHECK(hipDeviceSynchronize()); - auto elapsed = 0.0f; - HIP_CHECK(hipEventElapsedTime(&elapsed, start_event, stop_event)); - REQUIRE(static_cast(elapsed) >= interval); - } -} - TEST_CASE("Unit_hipExtModuleLaunchKernel_Positive_Parameters") { ModuleLaunchKernelPositiveParameters();