From d04acccc26bc6860cc4f93ac5e96c2ecc6577659 Mon Sep 17 00:00:00 2001 From: Jonathan Kim Date: Tue, 12 Sep 2023 15:51:58 -0400 Subject: [PATCH] Set correct overrides settings for GangLeader functions Silence warnings on more stringent compile checks for lack of override declaration. Signed-off-by: Jonathan Kim Change-Id: Iaa54dfc3dd74f5ee55763cafbbcf2db73493bb21 [ROCm/ROCR-Runtime commit: 6b4365ae4ce3c31536e7d6f5000657397a3e576b] --- .../runtime/hsa-runtime/core/inc/amd_blit_kernel.h | 4 ++-- .../rocr-runtime/runtime/hsa-runtime/core/inc/amd_blit_sdma.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/projects/rocr-runtime/runtime/hsa-runtime/core/inc/amd_blit_kernel.h b/projects/rocr-runtime/runtime/hsa-runtime/core/inc/amd_blit_kernel.h index 4fe7171ab6..8c45a1b2a2 100644 --- a/projects/rocr-runtime/runtime/hsa-runtime/core/inc/amd_blit_kernel.h +++ b/projects/rocr-runtime/runtime/hsa-runtime/core/inc/amd_blit_kernel.h @@ -114,8 +114,8 @@ class BlitKernel : public core::Blit { virtual uint64_t PendingBytes() override; - void GangLeader(bool gang_leader) override {} - bool GangLeader() const override { return false; } + virtual void GangLeader(bool gang_leader) override {} + virtual bool GangLeader() const override { return false; } private: union KernelArgs { diff --git a/projects/rocr-runtime/runtime/hsa-runtime/core/inc/amd_blit_sdma.h b/projects/rocr-runtime/runtime/hsa-runtime/core/inc/amd_blit_sdma.h index 10d676475e..672a03c95e 100644 --- a/projects/rocr-runtime/runtime/hsa-runtime/core/inc/amd_blit_sdma.h +++ b/projects/rocr-runtime/runtime/hsa-runtime/core/inc/amd_blit_sdma.h @@ -145,8 +145,8 @@ class BlitSdma : public BlitSdmaBase { virtual hsa_status_t EnableProfiling(bool enable) override; virtual uint64_t PendingBytes() override; - void GangLeader(bool gang_leader) override { gang_leader_ = gang_leader; } - bool GangLeader() const override { return gang_leader_; } + virtual void GangLeader(bool gang_leader) override { gang_leader_ = gang_leader; } + virtual bool GangLeader() const override { return gang_leader_; } private: /// @brief Acquires the address into queue buffer where a new command