Rename Omnitrace to ROCm Systems Profiler (#4)

The Omnitrace program is being renamed. 

Full name: "ROCm Systems Profiler"
Package name: "rocprofiler-systems"
Binary / Library names: "rocprof-sys-*"

---------
Co-authored-by: Xuan Chen <xuchen@amd.com>
Signed-off-by: David Galiffi <David.Galiffi@amd.com>

source/lib/binary/CMakeLists.txt

@@ -16,13 +16,17 @@ set(binary_headers
     ${CMAKE_CURRENT_LIST_DIR}/scope_filter.hpp
     ${CMAKE_CURRENT_LIST_DIR}/symbol.hpp)
 
-add_library(omnitrace-binary-library STATIC)
-add_library(omnitrace::omnitrace-binary ALIAS omnitrace-binary-library)
+add_library(rocprofiler-systems-binary-library STATIC)
+add_library(rocprofiler-systems::rocprofiler-systems-binary ALIAS
+            rocprofiler-systems-binary-library)
 
-target_sources(omnitrace-binary-library PRIVATE ${binary_sources} ${binary_headers})
+target_sources(rocprofiler-systems-binary-library PRIVATE ${binary_sources}
+                                                          ${binary_headers})
 
 target_link_libraries(
-    omnitrace-binary-library PRIVATE omnitrace::omnitrace-interface-library
-                                     omnitrace::omnitrace-core)
+    rocprofiler-systems-binary-library
+    PRIVATE rocprofiler-systems::rocprofiler-systems-interface-library
+            rocprofiler-systems::rocprofiler-systems-core)
 
-set_target_properties(omnitrace-binary-library PROPERTIES OUTPUT_NAME omnitrace-binary)
+set_target_properties(rocprofiler-systems-binary-library
+                      PROPERTIES OUTPUT_NAME ${BINARY_NAME_PREFIX}-binary)

source/lib/binary/address_multirange.cpp

@@ -1,6 +1,6 @@
 // MIT License
 //
-// Copyright (c) 2022 Advanced Micro Devices, Inc. All Rights Reserved.
+// Copyright (c) 2022-2024 Advanced Micro Devices, Inc. All Rights Reserved.
 //
 // Permission is hereby granted, free of charge, to any person obtaining a copy
 // of this software and associated documentation files (the "Software"), to deal
@@ -27,7 +27,7 @@
 #include <string>
 #include <utility>
 
-namespace omnitrace
+namespace rocprofsys
 {
 namespace binary
 {
@@ -72,4 +72,4 @@ address_multirange::operator+=(address_range _v)
     return *this;
 }
 }  // namespace binary
-}  // namespace omnitrace
+}  // namespace rocprofsys

source/lib/binary/address_multirange.hpp

@@ -1,6 +1,6 @@
 // MIT License
 //
-// Copyright (c) 2022 Advanced Micro Devices, Inc. All Rights Reserved.
+// Copyright (c) 2022-2024 Advanced Micro Devices, Inc. All Rights Reserved.
 //
 // Permission is hereby granted, free of charge, to any person obtaining a copy
 // of this software and associated documentation files (the "Software"), to deal
@@ -30,7 +30,7 @@
 #include <cstdint>
 #include <utility>
 
-namespace omnitrace
+namespace rocprofsys
 {
 namespace binary
 {
@@ -39,7 +39,7 @@ struct address_multirange
     struct coarse
     {};
 
-    OMNITRACE_DEFAULT_OBJECT(address_multirange)
+    ROCPROFSYS_DEFAULT_OBJECT(address_multirange)
 
     address_multirange& operator+=(std::pair<coarse, uintptr_t>&&);
     address_multirange& operator+=(std::pair<coarse, address_range>&& _v);
@@ -61,7 +61,7 @@ private:
 };
 
 template <typename Tp>
-OMNITRACE_INLINE bool
+ROCPROFSYS_INLINE bool
 address_multirange::contains(Tp&& _v) const
 {
     using type = concepts::unqualified_type_t<Tp>;
@@ -74,4 +74,4 @@ address_multirange::contains(Tp&& _v) const
                        [_v](auto&& itr) { return itr.contains(_v); });
 }
 }  // namespace binary
-}  // namespace omnitrace
+}  // namespace rocprofsys

source/lib/binary/analysis.cpp

@@ -1,6 +1,6 @@
 // MIT License
 //
-// Copyright (c) 2022 Advanced Micro Devices, Inc. All Rights Reserved.
+// Copyright (c) 2022-2024 Advanced Micro Devices, Inc. All Rights Reserved.
 //
 // Permission is hereby granted, free of charge, to any person obtaining a copy
 // of this software and associated documentation files (the "Software"), to deal
@@ -26,7 +26,7 @@
 #    error "BFD support not enabled"
 #endif
 
-#define PACKAGE "omnitrace"
+#define PACKAGE "rocprofiler-systems"
 
 #include <bfd.h>
 
@@ -60,7 +60,7 @@
 #include <set>
 #include <stdexcept>
 
-namespace omnitrace
+namespace rocprofsys
 {
 namespace binary
 {
@@ -75,7 +75,8 @@ parse_line_info(const std::string& _name, bool _process_dwarf, bool _process_bfd
     auto& _bfd = _info.bfd;
     _bfd       = std::make_shared<bfd_file>(_name);
 
-    OMNITRACE_BASIC_VERBOSE(0, "[binary] Reading line info for '%s'...\n", _name.c_str());
+    ROCPROFSYS_BASIC_VERBOSE(0, "[binary] Reading line info for '%s'...\n",
+                             _name.c_str());
 
     if(_bfd && _bfd->is_good())
     {
@@ -124,8 +125,8 @@ parse_line_info(const std::string& _name, bool _process_dwarf, bool _process_bfd
         _info.sort();
     }
 
-    OMNITRACE_BASIC_VERBOSE(1, "[binary] Reading line info for '%s'... %zu entries\n",
-                            _bfd->name.c_str(), _info.symbols.size());
+    ROCPROFSYS_BASIC_VERBOSE(1, "[binary] Reading line info for '%s'... %zu entries\n",
+                             _bfd->name.c_str(), _info.symbols.size());
 
     return _info;
 }
@@ -151,7 +152,7 @@ get_binary_info(const std::vector<std::string>&  _files,
     };
 
     // filter function used by procfs::get_contiguous_maps
-    // ensures that we do not process omnitrace/gotcha/libunwind libraries
+    // ensures that we do not process rocprof-sys/gotcha/libunwind libraries
     // and do not process the libraries outside of the binary scope
     auto _filter = [&_satisfies_binary_filter](const procfs::maps& _v) {
         if(_v.pathname.empty()) return false;
@@ -237,10 +238,10 @@ lookup_ipaddr_entry(uintptr_t _addr, unw_context_t* _context_p,
                 }
             };
 
-            for(const auto& itr : binary::get_link_map("libomnitrace.so", "", ""))
+            for(const auto& itr : binary::get_link_map("librocprof-sys.so", "", ""))
                 _insert_exclude_range(itr.real());
 
-            for(const auto& itr : binary::get_link_map("libomnitrace-dl.so", "", ""))
+            for(const auto& itr : binary::get_link_map("librocprof-sys-dl.so", "", ""))
                 _insert_exclude_range(itr.real());
 
             return _exclude_range_v;
@@ -305,4 +306,4 @@ lookup_ipaddr_entry<true>(uintptr_t, unw_context_t*, tim::unwind::cache*);
 template std::optional<tim::unwind::processed_entry>
 lookup_ipaddr_entry<false>(uintptr_t, unw_context_t*, tim::unwind::cache*);
 }  // namespace binary
-}  // namespace omnitrace
+}  // namespace rocprofsys

source/lib/binary/analysis.hpp

@@ -1,6 +1,6 @@
 // MIT License
 //
-// Copyright (c) 2022 Advanced Micro Devices, Inc. All Rights Reserved.
+// Copyright (c) 2022-2024 Advanced Micro Devices, Inc. All Rights Reserved.
 //
 // Permission is hereby granted, free of charge, to any person obtaining a copy
 // of this software and associated documentation files (the "Software"), to deal
@@ -44,7 +44,7 @@
 #include <tuple>
 #include <variant>
 
-namespace omnitrace
+namespace rocprofsys
 {
 namespace binary
 {
@@ -62,4 +62,4 @@ template <bool ExcludeInternal>
 std::optional<tim::unwind::processed_entry>
 lookup_ipaddr_entry(uintptr_t, unw_context_t* = nullptr, tim::unwind::cache* = nullptr);
 }  // namespace binary
-}  // namespace omnitrace
+}  // namespace rocprofsys

source/lib/binary/binary_info.hpp

@@ -1,6 +1,6 @@
 // MIT License
 //
-// Copyright (c) 2022 Advanced Micro Devices, Inc. All Rights Reserved.
+// Copyright (c) 2022-2024 Advanced Micro Devices, Inc. All Rights Reserved.
 //
 // Permission is hereby granted, free of charge, to any person obtaining a copy
 // of this software and associated documentation files (the "Software"), to deal
@@ -36,7 +36,7 @@
 #include <string>
 #include <vector>
 
-namespace omnitrace
+namespace rocprofsys
 {
 namespace binary
 {
@@ -84,4 +84,4 @@ binary_info::filename() const
     return (bfd) ? std::string{ bfd->name } : std::string{};
 }
 }  // namespace binary
-}  // namespace omnitrace
+}  // namespace rocprofsys

source/lib/binary/dwarf_entry.cpp

@@ -1,6 +1,6 @@
 // MIT License
 //
-// Copyright (c) 2022 Advanced Micro Devices, Inc. All Rights Reserved.
+// Copyright (c) 2022-2024 Advanced Micro Devices, Inc. All Rights Reserved.
 //
 // Permission is hereby granted, free of charge, to any person obtaining a copy
 // of this software and associated documentation files (the "Software"), to deal
@@ -28,7 +28,7 @@
 #include <dwarf.h>
 #include <elfutils/libdw.h>
 
-namespace omnitrace
+namespace rocprofsys
 {
 namespace binary
 {
@@ -206,20 +206,20 @@ template <typename ArchiveT>
 void
 dwarf_entry::serialize(ArchiveT& ar, const unsigned int)
 {
-#define OMNITRACE_SERIALIZE_MEMBER(MEMBER) ar(::tim::cereal::make_nvp(#MEMBER, MEMBER));
+#define ROCPROFSYS_SERIALIZE_MEMBER(MEMBER) ar(::tim::cereal::make_nvp(#MEMBER, MEMBER));
 
-    OMNITRACE_SERIALIZE_MEMBER(file)
-    OMNITRACE_SERIALIZE_MEMBER(line)
-    OMNITRACE_SERIALIZE_MEMBER(col)
-    OMNITRACE_SERIALIZE_MEMBER(address)
-    OMNITRACE_SERIALIZE_MEMBER(discriminator)
-    // OMNITRACE_SERIALIZE_MEMBER(begin_statement)
-    // OMNITRACE_SERIALIZE_MEMBER(end_sequence)
-    // OMNITRACE_SERIALIZE_MEMBER(line_block)
-    // OMNITRACE_SERIALIZE_MEMBER(prologue_end)
-    // OMNITRACE_SERIALIZE_MEMBER(epilogue_begin)
-    // OMNITRACE_SERIALIZE_MEMBER(vliw_op_index)
-    // OMNITRACE_SERIALIZE_MEMBER(isa)
+    ROCPROFSYS_SERIALIZE_MEMBER(file)
+    ROCPROFSYS_SERIALIZE_MEMBER(line)
+    ROCPROFSYS_SERIALIZE_MEMBER(col)
+    ROCPROFSYS_SERIALIZE_MEMBER(address)
+    ROCPROFSYS_SERIALIZE_MEMBER(discriminator)
+    // ROCPROFSYS_SERIALIZE_MEMBER(begin_statement)
+    // ROCPROFSYS_SERIALIZE_MEMBER(end_sequence)
+    // ROCPROFSYS_SERIALIZE_MEMBER(line_block)
+    // ROCPROFSYS_SERIALIZE_MEMBER(prologue_end)
+    // ROCPROFSYS_SERIALIZE_MEMBER(epilogue_begin)
+    // ROCPROFSYS_SERIALIZE_MEMBER(vliw_op_index)
+    // ROCPROFSYS_SERIALIZE_MEMBER(isa)
 }
 
 template void
@@ -234,4 +234,4 @@ template void
 dwarf_entry::serialize<cereal::PrettyJSONOutputArchive>(cereal::PrettyJSONOutputArchive&,
                                                         const unsigned int);
 }  // namespace binary
-}  // namespace omnitrace
+}  // namespace rocprofsys

source/lib/binary/dwarf_entry.hpp

@@ -1,6 +1,6 @@
 // MIT License
 //
-// Copyright (c) 2022 Advanced Micro Devices, Inc. All Rights Reserved.
+// Copyright (c) 2022-2024 Advanced Micro Devices, Inc. All Rights Reserved.
 //
 // Permission is hereby granted, free of charge, to any person obtaining a copy
 // of this software and associated documentation files (the "Software"), to deal
@@ -25,7 +25,7 @@
 #include "core/binary/address_range.hpp"
 #include "core/binary/fwd.hpp"
 
-namespace omnitrace
+namespace rocprofsys
 {
 namespace binary
 {
@@ -35,7 +35,7 @@ struct dwarf_entry
     using dwarf_tuple_t = std::tuple<std::deque<dwarf_entry>, std::vector<address_range>,
                                      std::vector<uintptr_t>>;
 
-    OMNITRACE_DEFAULT_OBJECT(dwarf_entry)
+    ROCPROFSYS_DEFAULT_OBJECT(dwarf_entry)
 
     bool          begin_statement = false;
     bool          end_sequence    = false;
@@ -63,4 +63,4 @@ struct dwarf_entry
     void serialize(ArchiveT&, const unsigned int);
 };
 }  // namespace binary
-}  // namespace omnitrace
+}  // namespace rocprofsys

source/lib/binary/link_map.cpp

@@ -1,6 +1,6 @@
 // MIT License
 //
-// Copyright (c) 2022 Advanced Micro Devices, Inc. All Rights Reserved.
+// Copyright (c) 2022-2024 Advanced Micro Devices, Inc. All Rights Reserved.
 //
 // Permission is hereby granted, free of charge, to any person obtaining a copy
 // of this software and associated documentation files (the "Software"), to deal
@@ -35,7 +35,7 @@
 #include <string>
 #include <string_view>
 
-namespace omnitrace
+namespace rocprofsys
 {
 namespace binary
 {
@@ -138,14 +138,14 @@ get_link_map(const char* _lib, const std::string& _exclude_linked_by,
     auto _name = (!_lib) ? config::get_exe_realpath() : std::string{ _lib };
     for(const auto& itr : _fini_chain)
     {
-        OMNITRACE_BASIC_VERBOSE(2, "[linkmap][%s]: %s\n", filepath::basename(_name),
-                                itr.real().c_str());
+        ROCPROFSYS_BASIC_VERBOSE(2, "[linkmap][%s]: %s\n", filepath::basename(_name),
+                                 itr.real().c_str());
     }
 
     for(const auto& itr : _excl_chain)
     {
-        OMNITRACE_BASIC_VERBOSE(3, "[linkmap][%s]: %s\n", _exclude_linked_by.c_str(),
-                                link_file{ itr }.real().c_str());
+        ROCPROFSYS_BASIC_VERBOSE(3, "[linkmap][%s]: %s\n", _exclude_linked_by.c_str(),
+                                 link_file{ itr }.real().c_str());
     }
 
     return _fini_chain;
@@ -178,4 +178,4 @@ link_file::real() const
     return filepath::realpath(name, nullptr, false);
 }
 }  // namespace binary
-}  // namespace omnitrace
+}  // namespace rocprofsys

source/lib/binary/link_map.hpp

@@ -1,6 +1,6 @@
 // MIT License
 //
-// Copyright (c) 2022 Advanced Micro Devices, Inc. All Rights Reserved.
+// Copyright (c) 2022-2024 Advanced Micro Devices, Inc. All Rights Reserved.
 //
 // Permission is hereby granted, free of charge, to any person obtaining a copy
 // of this software and associated documentation files (the "Software"), to deal
@@ -30,7 +30,7 @@
 #include <string_view>
 #include <vector>
 
-namespace omnitrace
+namespace rocprofsys
 {
 namespace binary
 {
@@ -54,11 +54,11 @@ std::optional<std::string>
 get_linked_path(const char*, open_modes_vec_t&& = {});
 
 // default parameters: get the linked binaries for the exe but exclude the linked binaries
-// from libomnitrace
+// from librocprof-sys
 std::set<link_file>
 get_link_map(const char*        _lib               = nullptr,
-             const std::string& _exclude_linked_by = "libomnitrace.so",
-             const std::string& _exclude_re        = "libomnitrace-([a-zA-Z]+)\\.so",
+             const std::string& _exclude_linked_by = "librocprof-sys.so",
+             const std::string& _exclude_re        = "librocprof-sys-([a-zA-Z]+)\\.so",
              open_modes_vec_t&& _open_modes        = {});
 }  // namespace binary
-}  // namespace omnitrace
+}  // namespace rocprofsys

source/lib/binary/scope_filter.cpp

@@ -1,6 +1,6 @@
 // MIT License
 //
-// Copyright (c) 2022 Advanced Micro Devices, Inc. All Rights Reserved.
+// Copyright (c) 2022-2024 Advanced Micro Devices, Inc. All Rights Reserved.
 //
 // Permission is hereby granted, free of charge, to any person obtaining a copy
 // of this software and associated documentation files (the "Software"), to deal
@@ -25,7 +25,7 @@
 
 #include <regex>
 
-namespace omnitrace
+namespace rocprofsys
 {
 namespace binary
 {
@@ -43,4 +43,4 @@ scope_filter::operator()(std::string_view _value) const
     throw exception<std::runtime_error>{ "invalid scope filter mode" };
 }
 }  // namespace binary
-}  // namespace omnitrace
+}  // namespace rocprofsys

source/lib/binary/scope_filter.hpp

@@ -1,6 +1,6 @@
 // MIT License
 //
-// Copyright (c) 2022 Advanced Micro Devices, Inc. All Rights Reserved.
+// Copyright (c) 2022-2024 Advanced Micro Devices, Inc. All Rights Reserved.
 //
 // Permission is hereby granted, free of charge, to any person obtaining a copy
 // of this software and associated documentation files (the "Software"), to deal
@@ -27,7 +27,7 @@
 #include <cstdint>
 #include <string>
 
-namespace omnitrace
+namespace rocprofsys
 {
 namespace binary
 {
@@ -55,7 +55,7 @@ struct scope_filter
 
     template <typename ContainerT>
     static bool satisfies_filter(const ContainerT&, filter_scope,
-                                 std::string_view) OMNITRACE_PURE;
+                                 std::string_view) ROCPROFSYS_PURE;
 };
 
 template <typename ContainerT>
@@ -72,4 +72,4 @@ scope_filter::satisfies_filter(const ContainerT& _filters, filter_scope _scope,
     return true;
 }
 }  // namespace binary
-}  // namespace omnitrace
+}  // namespace rocprofsys

source/lib/binary/symbol.cpp

@@ -1,6 +1,6 @@
 // MIT License
 //
-// Copyright (c) 2022 Advanced Micro Devices, Inc. All Rights Reserved.
+// Copyright (c) 2022-2024 Advanced Micro Devices, Inc. All Rights Reserved.
 //
 // Permission is hereby granted, free of charge, to any person obtaining a copy
 // of this software and associated documentation files (the "Software"), to deal
@@ -27,7 +27,7 @@
 #    error "BFD support not enabled"
 #endif
 
-#define PACKAGE     "omnitrace"
+#define PACKAGE     "rocprofiler-systems"
 #define L_LNNO_SIZE 4
 
 #include <bfd.h>
@@ -49,7 +49,7 @@
 
 #include <timemory/mpl/concepts.hpp>
 
-namespace omnitrace
+namespace rocprofsys
 {
 namespace binary
 {
@@ -404,4 +404,4 @@ template std::vector<dwarf_entry>
 symbol::get_debug_line_info<std::vector<dwarf_entry>>(
     const std::vector<scope_filter>& _filters) const;
 }  // namespace binary
-}  // namespace omnitrace
+}  // namespace rocprofsys

source/lib/binary/symbol.hpp

@@ -1,6 +1,6 @@
 // MIT License
 //
-// Copyright (c) 2022 Advanced Micro Devices, Inc. All Rights Reserved.
+// Copyright (c) 2022-2024 Advanced Micro Devices, Inc. All Rights Reserved.
 //
 // Permission is hereby granted, free of charge, to any person obtaining a copy
 // of this software and associated documentation files (the "Software"), to deal
@@ -32,7 +32,7 @@
 #include <string_view>
 #include <vector>
 
-namespace omnitrace
+namespace rocprofsys
 {
 namespace binary
 {
@@ -95,4 +95,4 @@ struct symbol : private tim::unwind::bfd_file::symbol
     std::vector<dwarf_entry>    dwarf_info   = {};
 };
 }  // namespace binary
-}  // namespace omnitrace
+}  // namespace rocprofsys