From d148e94161a3a0153830c5d10f702062b403b081 Mon Sep 17 00:00:00 2001 From: David Galiffi Date: Tue, 11 Feb 2025 17:36:31 -0500 Subject: [PATCH] Fix hang in config file generation (#101) - Updated Timemory module. - Fixes a crash when running rocprof-sys-avail -G without explicitly providing -F . The default value of "txt" was not being used. - Define "choices" before "default" when defining the "--config-format" argument in the parser. [ROCm/rocprofiler-systems commit: 3833c8d162d7225cf91b27d65183549125401419] --- projects/rocprofiler-systems/external/timemory | 2 +- .../rocprofiler-systems/source/bin/rocprof-sys-avail/avail.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/projects/rocprofiler-systems/external/timemory b/projects/rocprofiler-systems/external/timemory index 8c2afd3b2e..0eb3c2e897 160000 --- a/projects/rocprofiler-systems/external/timemory +++ b/projects/rocprofiler-systems/external/timemory @@ -1 +1 @@ -Subproject commit 8c2afd3b2e3d49916a1cee312e5314bb13f84d61 +Subproject commit 0eb3c2e897e95d91eb0333d52f1ea4887f32549f diff --git a/projects/rocprofiler-systems/source/bin/rocprof-sys-avail/avail.cpp b/projects/rocprofiler-systems/source/bin/rocprof-sys-avail/avail.cpp index afd7dd942e..2629e2b396 100644 --- a/projects/rocprofiler-systems/source/bin/rocprof-sys-avail/avail.cpp +++ b/projects/rocprofiler-systems/source/bin/rocprof-sys-avail/avail.cpp @@ -454,8 +454,8 @@ main(int argc, char** argv) parser.add_argument({ "-F", "--config-format" }, "Configuration file format") .min_count(1) .max_count(3) - .set_default(std::set{ "txt" }) .choices({ "txt", "json", "xml" }) + .set_default(std::set{ "txt" }) .dtype("filename") .action([&_config_fmts](parser_t& _p) { _config_fmts = _p.get>("config-format");