Miscellaneous Updates (const-correctness, logic fixes, etc.) (#126)

* Update lib/rocprofiler/hsa/hsa.cpp

- fix logic for constructing callback_contexts and buffered_contexts arrays

* Update include/rocprofiler/{agent,fwd,pc_sampling}.h

- remove rocprofiler_pc_sampling_config_array_t due to const problems
- update rocprofiler_agent_t to use arrays to const data
- remove redundant rocprofiler_query_pc_sampling_agent_configurations
  - this implementation is quite literally looking up info in the agent struct that was passed

* Update lib/rocprofiler/pc_sampling.cpp

- remove rocprofiler_query_pc_sampling_agent_configurations

* update lib/rocprofiler/agent.cpp

- handle const fields
- make mi200_pc_sampling_config variable static

* Update lib/rocprofiler/tests/agent.cpp

- tweak to pc_sampling_configs offset

* Update samples/pc_sampling

- Update sample to reflect minor tweaks to pc_sampling_configs in rocprofiler_agent_t

* Update CI workflow

- remove 'if: ${{ always() }}'
  - I suspect this is why the jobs do not cancel in progress correctly

source/lib/rocprofiler/hsa/hsa.cpp

@@ -198,22 +198,18 @@ hsa_api_impl<Idx>::functor(Args&&... args)
         if(itr->callback_tracer)
         {
             // if the given domain + op is not enabled, skip this context
-            if(!itr->callback_tracer->domains(info_type::callback_domain_idx,
-                                              info_type::operation_idx))
-                continue;
-
-            callback_contexts.emplace_back(
-                callback_context_data{itr, rocprofiler_callback_tracing_record_t{}});
+            if(itr->callback_tracer->domains(info_type::callback_domain_idx,
+                                             info_type::operation_idx))
+                callback_contexts.emplace_back(
+                    callback_context_data{itr, rocprofiler_callback_tracing_record_t{}});
         }
 
         if(itr->buffered_tracer)
         {
             // if the given domain + op is not enabled, skip this context
-            if(!itr->buffered_tracer->domains(info_type::buffered_domain_idx,
-                                              info_type::operation_idx))
-                continue;
-
-            buffered_contexts.emplace_back(buffered_context_data{itr});
+            if(itr->buffered_tracer->domains(info_type::buffered_domain_idx,
+                                             info_type::operation_idx))
+                buffered_contexts.emplace_back(buffered_context_data{itr});
         }
     }