From d2864edc692fc22a63d6ec1b40965d81e691ecea Mon Sep 17 00:00:00 2001 From: Alex Sierra Date: Fri, 4 Mar 2022 15:12:37 -0600 Subject: [PATCH] kfdtest: remove log message at hsaKmtSVMSetAttr failure This error messages should be handled by the caller. Signed-off-by: Alex Sierra Change-Id: I68d879d6d41835f47b8ac138c2218eaa6b86a512 [ROCm/ROCR-Runtime commit: dc33a092c0ebc4da736811d20d1718d04f90c04b] --- .../tests/kfdtest/src/KFDTestUtil.cpp | 24 +++++-------------- 1 file changed, 6 insertions(+), 18 deletions(-) diff --git a/projects/rocr-runtime/tests/kfdtest/src/KFDTestUtil.cpp b/projects/rocr-runtime/tests/kfdtest/src/KFDTestUtil.cpp index e52e7b496b..7473db456a 100644 --- a/projects/rocr-runtime/tests/kfdtest/src/KFDTestUtil.cpp +++ b/projects/rocr-runtime/tests/kfdtest/src/KFDTestUtil.cpp @@ -717,10 +717,8 @@ HSAKMT_STATUS RegisterSVMRange(HSAuint32 GPUNode, void *MemoryAddress, attrs[3].value = GPUNode; r = hsaKmtSVMSetAttr(MemoryAddress, SizeInBytes, nattr, attrs); - if (r) { - LOG() << "set range attrs failed" << std::endl; + if (r) return HSAKMT_STATUS_ERROR; - } return HSAKMT_STATUS_SUCCESS; } @@ -734,10 +732,8 @@ HSAKMT_STATUS SVMRangeGetPrefetchNode(void *MemoryAddress, HSAuint64 SizeInBytes attr.value = 0; r = hsaKmtSVMGetAttr(MemoryAddress, SizeInBytes, 1, &attr); - if (r) { - LOG() << "get prefetch node failed" << std::endl; + if (r) return HSAKMT_STATUS_ERROR; - } *PrefetchNode = attr.value; @@ -753,10 +749,8 @@ HSAKMT_STATUS SVMRangePrefetchToNode(void *MemoryAddress, HSAuint64 SizeInBytes, attr.value = PrefetchNode; r = hsaKmtSVMSetAttr(MemoryAddress, SizeInBytes, 1, &attr); - if (r) { - LOG() << "set prefetch node failed" << std::endl; + if (r) return HSAKMT_STATUS_ERROR; - } return HSAKMT_STATUS_SUCCESS; } @@ -770,10 +764,8 @@ HSAKMT_STATUS SVMRangeMapToNode(void *MemoryAddress, HSAuint64 SizeInBytes, attr.value = NodeID; r = hsaKmtSVMSetAttr(MemoryAddress, SizeInBytes, 1, &attr); - if (r) { - LOG() << "set map to node failed" << std::endl; + if (r) return HSAKMT_STATUS_ERROR; - } return HSAKMT_STATUS_SUCCESS; } @@ -787,10 +779,8 @@ HSAKMT_STATUS SVMRangeMapInPlaceToNode(void *MemoryAddress, HSAuint64 SizeInByte attr.value = NodeID; r = hsaKmtSVMSetAttr(MemoryAddress, SizeInBytes, 1, &attr); - if (r) { - LOG() << "set map in place to node failed" << std::endl; + if (r) return HSAKMT_STATUS_ERROR; - } return HSAKMT_STATUS_SUCCESS; } @@ -804,10 +794,8 @@ HSAKMT_STATUS SVMRangSetGranularity(void *MemoryAddress, HSAuint64 SizeInBytes, attr.value = Granularity; r = hsaKmtSVMSetAttr(MemoryAddress, SizeInBytes, 1, &attr); - if (r) { - LOG() << "set granularity failed" << std::endl; + if (r) return HSAKMT_STATUS_ERROR; - } return HSAKMT_STATUS_SUCCESS; }