Fixing Clang tidy errors (#195)

* Fixing Clang tidy errors

* format-fix

* Update code_object.hpp

* Clang Tidy Fixes on the whole Source folder

* Update source/CMakeLists.txt

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

* Addressing reviews

* Correcting the logic for parsing att counters

* Format Fix

* Update source/lib/rocprofiler-sdk-att/tests/dummy_decoder.cpp

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

* Update source/lib/rocprofiler-sdk-att/tests/standalone_tool_main.cpp

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

* Update source/lib/rocprofiler-sdk-tool/config.cpp

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

* Formatting

* Deactivate clang-tidy in source/lib/rocprofiler-sdk-att/tests

---------

Co-authored-by: Ammar ELWazir <aelwazir@amd.com>
Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

[ROCm/rocprofiler-sdk commit: 5410fabd3d]

projects/rocprofiler-sdk/source/lib/output/generateJSON.cpp

@@ -125,7 +125,7 @@ write_json(json_output&         json_ar,
         auto att_filenames                  = tool_metadata.get_att_filenames();
         auto code_object_snapshot_filenames = std::vector<std::string>{};
         code_object_snapshot_filenames.reserve(code_object_load_info.size());
-        for(auto info : code_object_load_info)
+        for(const auto& info : code_object_load_info)
         {
             code_object_snapshot_filenames.emplace_back(fs::path(info.name).filename());
         }

projects/rocprofiler-sdk/source/lib/output/metadata.cpp

@@ -240,9 +240,9 @@ std::vector<std::string>
 metadata::get_att_filenames() const
 {
     auto data = std::vector<std::string>{};
-    for(auto filenames : att_filenames)
+    for(const auto& filenames : att_filenames)
     {
-        for(auto file : filenames.second.second)
+        for(const auto& file : filenames.second.second)
         {
             data.emplace_back(fs::path(file).filename());
         }