From d47d3d3e9c18b07f5a668c503d2a06ed664f133e Mon Sep 17 00:00:00 2001 From: "Bhardwaj, Gopesh" Date: Wed, 4 Jun 2025 13:39:41 +0530 Subject: [PATCH] Fixing SDK compilation issues due to missing header (#433) [ROCm/rocprofiler-sdk commit: 918270bf634fae9f30351c9b1162e74f872ec204] --- .../samples/api_buffered_tracing/main.cpp | 9 +++++---- .../rocprofiler-sdk/samples/counter_collection/main.cpp | 3 ++- .../samples/external_correlation_id_request/main.cpp | 9 +++++---- projects/rocprofiler-sdk/samples/pc_sampling/main.cpp | 9 +++++---- .../rocprofiler-sdk/tests/bin/hip-graph/hip-graph.cpp | 5 +++-- 5 files changed, 20 insertions(+), 15 deletions(-) diff --git a/projects/rocprofiler-sdk/samples/api_buffered_tracing/main.cpp b/projects/rocprofiler-sdk/samples/api_buffered_tracing/main.cpp index 93b0631730..5ec6c3fe94 100644 --- a/projects/rocprofiler-sdk/samples/api_buffered_tracing/main.cpp +++ b/projects/rocprofiler-sdk/samples/api_buffered_tracing/main.cpp @@ -25,6 +25,7 @@ #include "common/defines.hpp" #include "hip/hip_runtime.h" +#include #include #include #include @@ -88,7 +89,7 @@ main(int argc, char** argv) client::start(); // starts context before any API tables are available client::identify(1); - auto* exe_name = ::basename(argv[0]); + auto* exe_name = basename(argv[0]); int rank = 0; for(int i = 1; i < argc; ++i) @@ -225,7 +226,7 @@ run(int rank, int tid, int devid, int argc, char** argv) void run_transpose(int rank, int tid, hipStream_t stream, int argc, char** argv) { - auto* exe_name = ::basename(argv[0]); + auto* exe_name = basename(argv[0]); unsigned int M = 4960 * 2; unsigned int N = 4960 * 2; @@ -314,7 +315,7 @@ run_scratch(int rank, int tid, hipStream_t stream, int, char** argv) HIP_API_CALL(hipStreamSynchronize(stream)); - const auto* exe_name = ::basename(argv[0]); + const auto* exe_name = basename(argv[0]); uint64_t* data_ptr = nullptr; HIP_API_CALL(HIP_HOST_ALLOC_FUNC(&data_ptr, sizeof(uint64_t), 0)); @@ -358,7 +359,7 @@ run_migrate(int rank, int tid, hipStream_t stream, int, char** argv) HIP_API_CALL(hipStreamSynchronize(stream)); - const auto* exe_name = ::basename(argv[0]); + const auto* exe_name = basename(argv[0]); auto page_data = std::vector(1024, 0); HIP_API_CALL(hipHostRegister( diff --git a/projects/rocprofiler-sdk/samples/counter_collection/main.cpp b/projects/rocprofiler-sdk/samples/counter_collection/main.cpp index a33f52c815..05b26fadf5 100644 --- a/projects/rocprofiler-sdk/samples/counter_collection/main.cpp +++ b/projects/rocprofiler-sdk/samples/counter_collection/main.cpp @@ -22,6 +22,7 @@ #include +#include #include "client.hpp" #define HIP_CALL(call) \ @@ -112,7 +113,7 @@ launchKernels(const long NUM_LAUNCH, const long SYNC_INTERVAL, const int DEV_ID) int main(int argc, char** argv) { - auto* exe_name = ::basename(argv[0]); + auto* exe_name = basename(argv[0]); int ntotdevice = 0; HIP_CALL(hipGetDeviceCount(&ntotdevice)); diff --git a/projects/rocprofiler-sdk/samples/external_correlation_id_request/main.cpp b/projects/rocprofiler-sdk/samples/external_correlation_id_request/main.cpp index 5064335768..bf7338908a 100644 --- a/projects/rocprofiler-sdk/samples/external_correlation_id_request/main.cpp +++ b/projects/rocprofiler-sdk/samples/external_correlation_id_request/main.cpp @@ -23,6 +23,7 @@ #include "common/defines.hpp" #include "hip/hip_runtime.h" +#include #include #include #include @@ -82,7 +83,7 @@ run_scratch(int rank, int tid, hipStream_t stream, int argc, char** argv); int main(int argc, char** argv) { - auto* exe_name = ::basename(argv[0]); + auto* exe_name = basename(argv[0]); int rank = 0; for(int i = 1; i < argc; ++i) @@ -214,7 +215,7 @@ run(int rank, int tid, int devid, int argc, char** argv) void run_transpose(int rank, int tid, hipStream_t stream, int argc, char** argv) { - auto* exe_name = ::basename(argv[0]); + auto* exe_name = basename(argv[0]); unsigned int M = 4960 * 2; unsigned int N = 4960 * 2; @@ -303,7 +304,7 @@ run_scratch(int rank, int tid, hipStream_t stream, int, char** argv) HIP_API_CALL(hipStreamSynchronize(stream)); - const auto* exe_name = ::basename(argv[0]); + const auto* exe_name = basename(argv[0]); uint64_t* data_ptr = nullptr; HIP_API_CALL(HIP_HOST_ALLOC_FUNC(&data_ptr, sizeof(uint64_t), 0)); @@ -347,7 +348,7 @@ run_migrate(int rank, int tid, hipStream_t stream, int, char** argv) HIP_API_CALL(hipStreamSynchronize(stream)); - const auto* exe_name = ::basename(argv[0]); + const auto* exe_name = basename(argv[0]); auto page_data = std::vector(1024, 0); HIP_API_CALL(hipHostRegister( diff --git a/projects/rocprofiler-sdk/samples/pc_sampling/main.cpp b/projects/rocprofiler-sdk/samples/pc_sampling/main.cpp index 5064335768..bf7338908a 100644 --- a/projects/rocprofiler-sdk/samples/pc_sampling/main.cpp +++ b/projects/rocprofiler-sdk/samples/pc_sampling/main.cpp @@ -23,6 +23,7 @@ #include "common/defines.hpp" #include "hip/hip_runtime.h" +#include #include #include #include @@ -82,7 +83,7 @@ run_scratch(int rank, int tid, hipStream_t stream, int argc, char** argv); int main(int argc, char** argv) { - auto* exe_name = ::basename(argv[0]); + auto* exe_name = basename(argv[0]); int rank = 0; for(int i = 1; i < argc; ++i) @@ -214,7 +215,7 @@ run(int rank, int tid, int devid, int argc, char** argv) void run_transpose(int rank, int tid, hipStream_t stream, int argc, char** argv) { - auto* exe_name = ::basename(argv[0]); + auto* exe_name = basename(argv[0]); unsigned int M = 4960 * 2; unsigned int N = 4960 * 2; @@ -303,7 +304,7 @@ run_scratch(int rank, int tid, hipStream_t stream, int, char** argv) HIP_API_CALL(hipStreamSynchronize(stream)); - const auto* exe_name = ::basename(argv[0]); + const auto* exe_name = basename(argv[0]); uint64_t* data_ptr = nullptr; HIP_API_CALL(HIP_HOST_ALLOC_FUNC(&data_ptr, sizeof(uint64_t), 0)); @@ -347,7 +348,7 @@ run_migrate(int rank, int tid, hipStream_t stream, int, char** argv) HIP_API_CALL(hipStreamSynchronize(stream)); - const auto* exe_name = ::basename(argv[0]); + const auto* exe_name = basename(argv[0]); auto page_data = std::vector(1024, 0); HIP_API_CALL(hipHostRegister( diff --git a/projects/rocprofiler-sdk/tests/bin/hip-graph/hip-graph.cpp b/projects/rocprofiler-sdk/tests/bin/hip-graph/hip-graph.cpp index 0b366cb86a..18562ed5ca 100644 --- a/projects/rocprofiler-sdk/tests/bin/hip-graph/hip-graph.cpp +++ b/projects/rocprofiler-sdk/tests/bin/hip-graph/hip-graph.cpp @@ -20,6 +20,7 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */ +#include #include #include #include @@ -171,7 +172,7 @@ run(uint64_t devid, int main(int argc, char* argv[]) { - std::cout << "[" << ::basename(argv[0]) << "] executing..." << std::endl; + std::cout << "[" << basename(argv[0]) << "] executing..." << std::endl; int ndevice_real = 0; checkHipErrors(hipGetDeviceCount(&ndevice_real)); @@ -214,6 +215,6 @@ main(int argc, char* argv[]) checkHipErrors(hipDeviceSynchronize()); } - std::cout << "[" << ::basename(argv[0]) << "] complete" << std::endl; + std::cout << "[" << basename(argv[0]) << "] complete" << std::endl; return 0; }