From d5bea2cfaafbd60050d78f499196f7a8bce43bf9 Mon Sep 17 00:00:00 2001 From: Dmitry Mikushin Date: Mon, 27 Jun 2022 19:44:43 +0200 Subject: [PATCH] Adding the missing roc:: namespace (#570) * Adding the missing roc:: namespace, effectively changing the value of RCCL_LIBRARY from rccl to roc::rccl. The important difference is that rccl is treated as a symbolic "-lrccl" by linker (and fail the linking due to a missing library search path), while roc::rccl is a target name, which can resolve into an absolute library path. Co-authored-by: Paul Fultz II * Adding a changelog entry * minor updates to wording * missing period Co-authored-by: Paul Fultz II Co-authored-by: Saad Rahim <44449863+saadrahim@users.noreply.github.com> --- CHANGELOG.md | 2 ++ CMakeLists.txt | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e0e7913240..0feab091bd 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,8 @@ Full documentation for RCCL is available at [https://rccl.readthedocs.io](https: ## (Unreleased) RCCL-2.12.10 ### Added - Compatibility with NCCL 2.12.10 +- Changing CMake exported target name from rccl to roc::rccl. This aligns RCCL to other ROCm + components. Users may need to update their build systems. - Packages for test and benchmark executables on all supported OSes using CPack. - Adding custom signal handler - opt-in with RCCL_ENABLE_SIGNALHANDLER=1 - Additional details provided if Binary File Descriptor library (BFD) is pre-installed diff --git a/CMakeLists.txt b/CMakeLists.txt index 1aa2a7c668..9d46381506 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -348,7 +348,7 @@ rocm_install(FILES ${PROJECT_BINARY_DIR}/include/rccl/rccl.h rocm_export_targets(NAMESPACE roc:: TARGETS - rccl + roc::rccl DEPENDS hip) if(BUILD_FILE_REORG_BACKWARD_COMPATIBILITY)