From da183596cdc07eb9120b52db13bed8460ee5ee4a Mon Sep 17 00:00:00 2001 From: isaki001 <36317038+isaki001@users.noreply.github.com> Date: Tue, 25 Nov 2025 15:22:34 -0600 Subject: [PATCH] add back missing proxy-counter updates (#2052) --- src/transport/net.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/transport/net.cc b/src/transport/net.cc index 2c349fae10..23e8ebce3d 100644 --- a/src/transport/net.cc +++ b/src/transport/net.cc @@ -1481,6 +1481,8 @@ static ncclResult_t sendProxyProgress(struct ncclProxyState* proxyState, struct TRACE(NCCL_NET, "sendProxy [%ld/%d/%d] request %p done", sub->done, buffSlot, sub->nsteps, sub->requests[buffSlot]); sub->done += args->sliceSteps; ncclProfilerStopProxyStepEvent(s, args, doneStepId); + facebook_rccl::updateProxyOpCounter(proxyState->proxyTrace, sub->traceKey, + facebook_rccl::ProxyCounterTypes::DONE, sub->done); if (resources->shared == 0) { volatile uint64_t* sendHead = resources->gdcSync ? resources->gdcSync : &resources->sendMem->head; *sendHead = sub->base + sub->done; @@ -1823,6 +1825,7 @@ static ncclResult_t recvProxyProgress(struct ncclProxyState* proxyState, struct int doneStepId = sub->done; sub->done += args->sliceSteps; ncclProfilerStopProxyStepEvent(s+i, args, doneStepId); + facebook_rccl::updateProxyOpCounter(proxyState->proxyTrace, sub->traceKey, facebook_rccl::ProxyCounterTypes::DONE, sub->done); args->idle = 0; if (sub->done == sub->nsteps) { args->done++;