Cleanup + logging env variable (#387)

* [CP] Update tests/common/serialization.hpp

- remove duplication in rocprofiler_callback_tracing_code_object_load_data_t

* [CP] Update lib/rocprofiler-sdk/tests

- create common.hpp
- update registration.cpp to use common.hpp

* [CP] Add lib/common/logging.{hpp,cpp}

- generic init_logging function

* [CP] Update lib/rocprofiler-sdk/hsa/async_copy.cpp

- remove excess logging

* [CP] Update lib/rocprofiler-sdk/registration.cpp

- use common::init_logging(...)
- enforce ROCPROFILER_REGISTER_FORCE_LOAD in rocprofiler_force_configure
- logging updates in rocprofiler_set_api_table

* Update include/rocprofiler-sdk/buffer_tracing.h

- rocprofiler_buffer_tracing_marker_record_t -> rocprofiler_buffer_tracing_marker_api_record_t

* Update lib/common/utility.hpp

- remove active_capacity_gate

* Update lib/rocprofiler-sdk/tests/common.hpp

- fix get_{callback,buffer}_tracing_names()

* Update lib/rocprofiler-sdk/counters/xml/{basic,derived}_counters.xml

- add entries for gfx1102
This commit is contained in:
Jonathan R. Madsen
2024-01-17 00:28:20 -06:00
committed by GitHub
parent 0952308c4a
commit dc8b8aa448
12 changed files with 341 additions and 239 deletions
@@ -103,8 +103,6 @@ convert_hsa_handle(Up _hsa_object)
bool
async_copy_handler(hsa_signal_value_t signal_value, void* arg)
{
LOG(ERROR) << "[" << __FUNCTION__ << "] invoked with signal value " << signal_value;
static auto sysclock_period = []() -> uint64_t {
constexpr auto nanosec = 1000000000UL;
uint64_t sysclock_hz = 0;
@@ -123,9 +121,6 @@ async_copy_handler(hsa_signal_value_t signal_value, void* arg)
copy_time.start *= sysclock_period;
copy_time.end *= sysclock_period;
LOG(ERROR) << "[" << __FUNCTION__ << "] start=" << copy_time.start << ", end=" << copy_time.end
<< ", delta=" << (copy_time.end - copy_time.start) << ", period=" << sysclock_period;
// if we encounter this in CI, it will cause test to fail
ROCP_CI_LOG_IF(ERROR, copy_time_status == HSA_STATUS_SUCCESS && copy_time.end < copy_time.start)
<< "hsa_amd_profiling_get_async_copy_time for returned async times where the end time ("
@@ -204,8 +199,6 @@ async_copy_handler(hsa_signal_value_t signal_value, void* arg)
delete _data;
}
LOG(ERROR) << "[" << __FUNCTION__ << "] completed (signal value " << signal_value << ")";
return (signal_value > 0);
}
@@ -257,8 +250,6 @@ async_copy_impl(Args... args)
constexpr auto N = sizeof...(Args);
LOG(ERROR) << "[" << __FUNCTION__ << "] started...";
auto&& _tied_args = std::tie(args...);
auto ctxs = context::get_active_contexts(context_filter);
@@ -415,8 +406,6 @@ async_copy_impl(Args... args)
_data->orig_signal = _completion_signal;
_completion_signal = _data->rocp_signal;
auto _dtor = common::scope_destructor{[]() { LOG(ERROR) << "[async_copy_impl] ... returned"; }};
return invoke(get_next_dispatch<Idx>(), std::move(_tied_args), std::make_index_sequence<N>{});
}