AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix incorrect pointer checking for scatter and gather (#285)

Browse Source
This commit is contained in:
Wenkai Du
2020-10-19 13:27:09 -07:00
committed by GitHub
parent 9b3f762b68
commit dcad0ef7cb
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/misc/argcheck.cc
+2 -2
View File
@@ -73,10 +73,10 @@ ncclResult_t ArgsCheck(struct ncclInfo* info) {
} }
} else { } else {
// Check CUDA device pointers // Check CUDA device pointers
if (info->coll != ncclCollBroadcast || info->comm->rank == info->root) { if ((info->coll != ncclCollBroadcast && info->coll != ncclCollScatter) || info->comm->rank == info->root) {
NCCLCHECK(CudaPtrCheck(info->sendbuff, info->comm, "sendbuff", info->opName)); NCCLCHECK(CudaPtrCheck(info->sendbuff, info->comm, "sendbuff", info->opName));
} }
if (info->coll != ncclCollReduce || info->comm->rank == info->root) { if ((info->coll != ncclCollReduce && info->coll != ncclCollGather) || info->comm->rank == info->root) {
NCCLCHECK(CudaPtrCheck(info->recvbuff, info->comm, "recvbuff", info->opName)); NCCLCHECK(CudaPtrCheck(info->recvbuff, info->comm, "recvbuff", info->opName));
} }
} }