From de069729a58334227568c059dc5a3cd69540b5b8 Mon Sep 17 00:00:00 2001 From: Satyanvesh Dittakavi Date: Thu, 17 Mar 2022 12:21:27 +0000 Subject: [PATCH] SWDEV-318123 - Address hipGraphHostNodeSetParams negative scenarios Change-Id: I4884a364b40e93c779ca84f34eee4688f3583aab --- hipamd/src/hip_graph.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hipamd/src/hip_graph.cpp b/hipamd/src/hip_graph.cpp index 03ad8d5ee7..95cfc4e868 100644 --- a/hipamd/src/hip_graph.cpp +++ b/hipamd/src/hip_graph.cpp @@ -1711,7 +1711,8 @@ hipError_t hipGraphHostNodeGetParams(hipGraphNode_t node, hipHostNodeParams* pNo hipError_t hipGraphHostNodeSetParams(hipGraphNode_t node, const hipHostNodeParams* pNodeParams) { HIP_INIT_API(hipGraphHostNodeSetParams, node, pNodeParams); - if (pNodeParams->fn == nullptr || pNodeParams->userData == nullptr) { + if (pNodeParams == nullptr || pNodeParams->fn == nullptr || pNodeParams->userData == nullptr || + node == nullptr || !hipGraphNode::isNodeValid(node)) { HIP_RETURN(hipErrorInvalidValue); } HIP_RETURN(reinterpret_cast(node)->SetParams(pNodeParams)); @@ -1720,8 +1721,8 @@ hipError_t hipGraphHostNodeSetParams(hipGraphNode_t node, const hipHostNodeParam hipError_t hipGraphExecHostNodeSetParams(hipGraphExec_t hGraphExec, hipGraphNode_t node, const hipHostNodeParams* pNodeParams) { HIP_INIT_API(hipGraphExecHostNodeSetParams, hGraphExec, node, pNodeParams); - if (hGraphExec == nullptr || pNodeParams == nullptr || - pNodeParams->fn == nullptr || pNodeParams->userData == nullptr) { + if (hGraphExec == nullptr || pNodeParams == nullptr || pNodeParams->fn == nullptr || + pNodeParams->userData == nullptr || node == nullptr || !hipGraphNode::isNodeValid(node)) { HIP_RETURN(hipErrorInvalidValue); } hipGraphNode_t clonedNode = hGraphExec->GetClonedNode(node);