P4 to Git Change 1610043 by gandryey@gera-w8 on 2018/09/24 18:08:36

SWDEV-79445 - OCL generic changes and code clean-up
	Program compilation clean-up. Step#3:
	- Move getCompilationStagesFromBinary and getNextCompilationStageFromBinary to the abstraction layer.
	- Share the same functionality across GSL, PAL and ROCr backends

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.cpp#3 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.hpp#3 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuprogram.cpp#243 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuprogram.hpp#76 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldefs.hpp#39 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palprogram.cpp#75 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palprogram.hpp#31 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprogram.cpp#88 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprogram.hpp#37 edit

rocclr/runtime/device/rocm/rocprogram.hpp

@@ -72,17 +72,6 @@ class Program : public device::Program {
   }
 
  protected:
-  /* \brief Returns the next stage to compile from, based on sections in binary,
-   *  also returns completeStages in a vector, which contains at least ACL_TYPE_DEFAULT,
-   *  sets needOptionsCheck to true if options check is needed to decide whether or not to recompile
-   */
-  virtual aclType getCompilationStagesFromBinary(std::vector<aclType>& completeStages,
-                                         bool& needOptionsCheck) = 0;
-
-  /* \brief Returns the next stage to compile from, based on sections and options in binary
-   */
-  aclType getNextCompilationStageFromBinary(amd::option::Options* options);
-
   //! Disable default copy constructor
   Program(const Program&) = delete;
   //! Disable operator=
@@ -111,9 +100,6 @@ class HSAILProgram : public roc::Program {
 private:
   std::string codegenOptions(amd::option::Options* options);
 
-  virtual aclType getCompilationStagesFromBinary(std::vector<aclType>& completeStages,
-                                                 bool& needOptionsCheck) final;
-
   bool saveBinaryAndSetType(type_t type);
 };
 #endif // defined(WITH_COMPILER_LIB)
@@ -140,9 +126,6 @@ protected:
 private:
   bool saveBinaryAndSetType(type_t type, void* rawBinary, size_t size);
 
-  virtual aclType getCompilationStagesFromBinary(std::vector<aclType>& completeStages,
-                                                 bool& needOptionsCheck) final;
-
   bool setKernels(amd::option::Options* options, void* binary, size_t binSize);
 
   CodeObjectMD* metadata_;  //!< Runtime metadata