kfdtest: Style cleanup
Clean up the KFDTest style via CPPLint. Some warnings remain regarding volatile variables being cast to void*. This is the command used: cpplint.py --linelength=120 --filter=-readability/multiline_string,-readability/todo,-build/include,-runtime/references multiline_string is due to using ISA code todo is to avoid errors that we don't have TODO(username) instead of TODO include is about including the folder in the header includes references is regarding non-const references '&' being const or using pointers. That can be addressed later Change-Id: I3c6622da0a13dd33ab29b2bfff48be25e763b750
Este commit está contenido en:
@@ -24,9 +24,6 @@
|
||||
#define __KFD_BASE_COMPONENT_TEST__H__
|
||||
|
||||
#include <gtest/gtest.h>
|
||||
#include "hsakmt.h"
|
||||
#include "OSWrapper.hpp"
|
||||
#include "KFDTestUtil.hpp"
|
||||
#include <sys/types.h>
|
||||
#include <sys/stat.h>
|
||||
#include <fcntl.h>
|
||||
@@ -34,6 +31,9 @@
|
||||
#include <amdgpu.h>
|
||||
#include <amdgpu_drm.h>
|
||||
#include <sys/param.h>
|
||||
#include "hsakmt.h"
|
||||
#include "OSWrapper.hpp"
|
||||
#include "KFDTestUtil.hpp"
|
||||
|
||||
// @class KFDBaseComponentTest
|
||||
class KFDBaseComponentTest : public testing::Test {
|
||||
@@ -63,13 +63,17 @@ class KFDBaseComponentTest : public testing::Test {
|
||||
HsaMemFlags m_MemoryFlags;
|
||||
HsaNodeInfo m_NodeInfo;
|
||||
|
||||
// @brief SetUpTestCase function run before the first test that uses KFDOpenCloseKFDTest class fixture, and opens KFD.
|
||||
// @brief SetUpTestCase function run before the first test that uses
|
||||
// KFDOpenCloseKFDTest class fixture, and opens KFD.
|
||||
static void SetUpTestCase();
|
||||
// @brief TearDownTestCase function run after the last test from KFDOpenCloseKFDTest class fixture and calls close KFD.
|
||||
// @brief TearDownTestCase function run after the last test from
|
||||
// KFDOpenCloseKFDTest class fixture and calls close KFD.
|
||||
static void TearDownTestCase();
|
||||
// @brief SetUp function run before every test that uses KFDOpenCloseKFDTest class fixture, sets all common settings for the tests.
|
||||
// @brief SetUp function run before every test that uses
|
||||
// KFDOpenCloseKFDTest class fixture, sets all common settings for the tests.
|
||||
virtual void SetUp();
|
||||
// @brief TearDown function run after every test that uses KFDOpenCloseKFDTest class fixture.
|
||||
// @brief TearDown function run after every test that uses
|
||||
// KFDOpenCloseKFDTest class fixture.
|
||||
virtual void TearDown();
|
||||
};
|
||||
|
||||
|
||||
Referencia en una nueva incidencia
Block a user